[Fix] Stream large file downloads in validate - #948
Merged
Merged
Conversation
Use apiStream and fileCreateFromStream from core 0.1.60 so files over 2GB no longer fail with a Buffer length error. Verified against the 2.3GB VSCO-2-CE archive. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validation failed for files larger than 2GB (e.g. VSCO-2-CE, 2.3GB) because the download was buffered in memory and written with a single
writeFileSynccall.@open-audio-stack/coreto ^0.1.60src/validate.tsnow usesapiStream+fileCreateFromStreamto stream the download to diskTested by running
npm run dev:validateagainst the pinned VSCO-2-CE archive URL: the full 2,297,836,334 byte zip downloads and is hashed correctly (previously a 0 byte file and a "length out of range" error).npm run checkpasses.Closes open-audio-stack/open-audio-stack-core#112
🤖 Generated with Claude Code