Add VSCO2 samples - #949
Merged
Merged
Conversation
Contributor
Author
|
Sorry, I thought CI wouldn't run if I open this as draft PR. Anyway, forgot the virus total link: |
savashn
marked this pull request as ready for review
September 21, 2026 21:04
Contributor
Author
|
I have no idea how to solve the virus total check for the files over 2 GB :/ |
Member
|
VirusTotal link via url worked, so no issue there. One change for the image preview, can you show the instrument or brand rather than the instrument loaded into sfz? otherwise it looks like the sampler rather than the instrument pack. It's fine to use a photo similar to other sfz instruments: |
Contributor
Author
|
Got it. Is that photo fine? Received from this page |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Once the #948 merged, need to check this PR again