Repository navigation
[stack] fix(mail): drop the page margin around emails on phones - #65296
Merged
Merged
Conversation
skjnldsv
requested review from
a team,
ChristophWurst,
SebastianKrupinski and
tcitworld
as code owners
October 7, 2026 19:16
skjnldsv
added
enhancement
3. to review
skjnldsv
requested review from
Altahrim,
jancborchardt,
leftybournes,
pabzm,
salmart-dev and
sorbaugh
and removed request for
a team and
sorbaugh
October 7, 2026 19:16
skjnldsv
added this pull request to stack #65223
October 7, 2026 19:18
skjnldsv
force-pushed
the
feature/mail-template-followups
branch
2 times, most recently
from
October 8, 2026 00:56
0bacf15 to
bce9b65
Compare
skjnldsv
force-pushed
the
feature/mail-template-followups
branch
from
October 8, 2026 06:21
bce9b65 to
d92c875
Compare
Member
Author
|
@jancborchardt this is the final pr. Feel free to suggest other changes 😊 |
jancborchardt
previously requested changes
Oct 8, 2026
jancborchardt
left a comment
jancborchardt
left a comment
Member
There was a problem hiding this comment.
Thanks for the bar change!
As for description relocation, it is sort of unexpected for the description to come before basic details like date and time.
Yes, for file shares it makes sense to put the "Note" above further details cause a short note is intended by the interface, but event descriptions can get quite long.
Member
Author
|
@jancborchardt so we keep the note only above for SHares ? And for all the other after the main content ? |
5 of 7 tasks
On narrow screens the card now fills the screen without the page margin, so the colored header sits at the top. Tests now also pin where notes go: before the details card for shares, after it for calendar events and the email changed mail. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: John Molakvoæ <14975046+skjnldsv@users.noreply.github.com>
skjnldsv
force-pushed
the
feature/mail-template-followups
branch
from
October 8, 2026 13:00
d92c875 to
24ee183
Compare
skjnldsv
changed the title
jancborchardt
approved these changes
Oct 8, 2026
jancborchardt
left a comment
jancborchardt
left a comment
Member
There was a problem hiding this comment.
Nice, thanks! And yeah, definitely description below details is best for Calendar events.
kesselb
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Builds on #65226. On phones the colored header now sits at the very top, without the grey margin above the card.
Notes stay before the details card for shares and after it for calendar events, see the discussion with Jan above.
Checklist
AI (if applicable)
👾 This pull request was assisted by Claude Code, commits carry an
Assisted-bytrailer.