Repository navigation
[stack] feat(mail): support right-to-left languages in emails - #65312
Merged
Merged
Conversation
skjnldsv
added
enhancement
3. to review
skjnldsv
requested review from
a team,
ChristophWurst,
SebastianKrupinski and
tcitworld
as code owners
October 8, 2026 12:21
skjnldsv
requested review from
Altahrim,
leftybournes,
salmart-dev and
sorbaugh
and removed request for
a team
October 8, 2026 12:21
SebastianKrupinski
approved these changes
Oct 8, 2026
skjnldsv
requested review from
jancborchardt and
nickvergessen
and removed request for
sorbaugh
October 8, 2026 12:58
skjnldsv
added this pull request to stack #65223
October 8, 2026 12:58
skjnldsv
force-pushed
the
feature/mail-template-rtl
branch
from
October 8, 2026 13:00
6e3b09e to
8eca3e1
Compare
hamza221
approved these changes
Oct 8, 2026
Member
Author
I think it's just because it's a new string and haven't a translation yet. I'm not sure we can actually differenciate line per line if we render ltr or rtl. This should be fixed the moment our translations gets updated :) |
IEMailTemplate::setLanguage() sets the lang and dir attributes of the email, mirrors the layout for right-to-left languages and becomes the default language of the footer. Every email sent by server now passes the language it is written in. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: John Molakvoæ <14975046+skjnldsv@users.noreply.github.com>
skjnldsv
force-pushed
the
feature/mail-template-rtl
branch
from
October 8, 2026 19:20
8eca3e1 to
9629175
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Builds on #65296. Emails ignored the recipient's language for layout: everything was
lang="en", left to right, so Arabic or Hebrew mails had text stuck to the left, punctuation on the wrong side and the note bar on the wrong edge.IEMailTemplate::setLanguage()fixes that: it setslanganddiron the email, mirrors the layout for right-to-left languages, and is the default language for the footer. Every email in server now passes the language it's written in.The mirroring swaps left and right in the template's own styles only (style attributes and the style element), so text like "Turn left" is never touched. Logical CSS properties would be nicer, but mail clients don't support them.
Rendered with the server's real Arabic translations. Strings added in this release ("Note", "Valid until", the footer) aren't translated yet.
Checklist
AI (if applicable)
👾 This pull request was assisted by Claude Code, commits carry an
Assisted-bytrailer.