Skip to content

[stack] feat(mail): say on whose behalf an email was sent in the footer - #65226

Merged
skjnldsv merged 1 commit into
masterfrom
feature/mail-footer-sender
Oct 8, 2026
Merged

skjnldsv merged 1 commit into
masterfrom
feature/mail-footer-sender

Conversation

@skjnldsv

@skjnldsv skjnldsv commented Oct 6, 2026 •

Copy link
Copy Markdown
Member

Summary

Builds on #65222. When a mail shows who it comes from, the footer now says it too: "This email was sent from cloud.example.com on behalf of Alice Martin." instead of "please do not reply". Mails without a sender keep today's footer, and a custom footer still wins.

The share mails had their own footer logic for this, it's gone now. Calendar invites and delegation mails get the new line for free.

New string: "This email was sent from %1$s on behalf of %2$s."

Before After (light) After (dark) Mobile
before-user-share user-share-light user-share-dark user-share-mobile

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests are included
  • Screenshots before/after for front-end changes
  • Documentation has been updated or is not required
  • Backports requested where applicable
  • Labels added where applicable
  • Milestone added for target branch/version

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

👾 This pull request was assisted by Claude Code, commits carry an Assisted-by trailer.

@skjnldsv skjnldsv added this to the Nextcloud 36 milestone Oct 6, 2026
@skjnldsv skjnldsv self-assigned this Oct 6, 2026
@skjnldsv
skjnldsv requested review from CarlSchwan, come-nc, icewind1991 and provokateurin and removed request for a team October 6, 2026 20:36
@skjnldsv
skjnldsv force-pushed the feature/mail-footer-sender branch from c47758b to 1677b5f Compare October 7, 2026 09:34
@skjnldsv
skjnldsv added this pull request to stack #65223 October 7, 2026 09:58

@jancborchardt jancborchardt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good, just wondering if it needs to be more present than that?

@skjnldsv
skjnldsv force-pushed the feature/mail-footer-sender branch from 1677b5f to a5e6a72 Compare October 7, 2026 16:43
@skjnldsv
skjnldsv force-pushed the feature/mail-footer-sender branch 3 times, most recently from 9787f39 to 5c3f129 Compare October 7, 2026 18:17
@skjnldsv
skjnldsv requested a review from pabzm October 7, 2026 19:17
Base automatically changed from feature/security-mail-notes to master October 8, 2026 00:56
When an email has a sender block, the default footer now reads "This
email was sent from <instance> on behalf of <name>." instead of the
"do not reply" line. The share mails no longer need their own footer
for that.

Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: John Molakvoæ <14975046+skjnldsv@users.noreply.github.com>
@skjnldsv
skjnldsv force-pushed the feature/mail-footer-sender branch from 5c3f129 to a11f2f0 Compare October 8, 2026 00:56
@skjnldsv
skjnldsv merged commit 84d471a into master Oct 8, 2026
155 checks passed
@skjnldsv
skjnldsv deleted the feature/mail-footer-sender branch October 8, 2026 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants