🐛 Preserve jeff entry-point results#1934
Merged
Merged
Conversation
burgholzer
added
fix
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
denialhaag
changed the title
jeff entry-point results
Assisted-by: GPT-5.6 via Codex
Assisted-by: GPT-5.6 via Codex
Assisted-by: GPT-5.6 via Codex
burgholzer
force-pushed
the
agent/1910-jeff-results
branch
from
July 24, 2026 16:07
566035d to
101317d
Compare
burgholzer
marked this pull request as ready for review
July 24, 2026 16:22
burgholzer
added a commit
that referenced
this pull request
Jul 24, 2026
🤖 *AI text below* 🤖 ## Summary - Insert the synthesized Jeff status return at the original terminator position. - Add a regression for result-less Jeff entry points with operations in the body. - Treat `mlir/**` changes as Python-relevant so binding-level tests and lint run on affected pull requests. ## Root cause The entry-point restoration introduced in #1934 created the replacement `func.return` at the current rewriter insertion point, which remained near the start of the block after creating the zero status constant. Result-less Jeff programs therefore placed operations after the terminator and failed conversion. The original pull request did not expose this through Python because the shared change detector did not classify `mlir/**` changes as Python-relevant, so all Python jobs were skipped. ## Impact Serialized result-less Jeff programs can again be compiled through the Python `compile_program` entry point. Future MLIR changes will exercise the Python bindings in pull-request CI. ## Validation - Jeff round-trip suite: 117 passed - Jeff entry-point regressions: 2 passed - Exact failing Python test: 1 passed - Full Python suite: 394 passed, 3 skipped - Repository lint and GitHub workflow validation: passed - `git diff --check`: passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI text below 🤖
Summary
entry point back to QCO.
i64status result only for result-less entry points.Context
This independent Jeff conversion issue was found while exercising programs from
the OpenQASM integration in #1910. Jeff compatibility is not a prerequisite for
accepting an OpenQASM program, but when a supported program is converted through
Jeff, the conversion must not silently replace its observable result.
Validation
uvx prek run --from-ref origin/main --to-ref HEADgit diff --check origin/main...HEAD