Skip to content

🐛 Fix jeff status return placement#1939

Merged
burgholzer merged 1 commit into
mainfrom
agent/fix-jeff-main-ci
Jul 24, 2026
Merged

🐛 Fix jeff status return placement#1939
burgholzer merged 1 commit into
mainfrom
agent/fix-jeff-main-ci

Conversation

@burgholzer

Copy link
Copy Markdown
Member

🤖 AI text below 🤖

Summary

  • Insert the synthesized Jeff status return at the original terminator position.
  • Add a regression for result-less Jeff entry points with operations in the body.
  • Treat mlir/** changes as Python-relevant so binding-level tests and lint run on affected pull requests.

Root cause

The entry-point restoration introduced in #1934 created the replacement func.return at the current rewriter insertion point, which remained near the start of the block after creating the zero status constant. Result-less Jeff programs therefore placed operations after the terminator and failed conversion.

The original pull request did not expose this through Python because the shared change detector did not classify mlir/** changes as Python-relevant, so all Python jobs were skipped.

Impact

Serialized result-less Jeff programs can again be compiled through the Python compile_program entry point. Future MLIR changes will exercise the Python bindings in pull-request CI.

Validation

  • Jeff round-trip suite: 117 passed
  • Jeff entry-point regressions: 2 passed
  • Exact failing Python test: 1 passed
  • Full Python suite: 394 passed, 3 skipped
  • Repository lint and GitHub workflow validation: passed
  • git diff --check: passed

Assisted-by: GPT-5.6 via Codex
@codecov

codecov Bot commented Jul 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@burgholzer burgholzer self-assigned this Jul 24, 2026
@burgholzer burgholzer added fix Fix for something that isn't working MLIR Anything related to MLIR labels Jul 24, 2026
@burgholzer burgholzer added this to the MLIR Support milestone Jul 24, 2026
@burgholzer
burgholzer marked this pull request as ready for review July 24, 2026 22:34
@burgholzer
burgholzer enabled auto-merge (squash) July 24, 2026 22:34
@burgholzer
burgholzer merged commit 013aef0 into main Jul 24, 2026
33 checks passed
@burgholzer
burgholzer deleted the agent/fix-jeff-main-ci branch July 24, 2026 23:16
burgholzer added a commit that referenced this pull request Jul 24, 2026
Integrate the Python CI and Jeff return-placement fixes from #1939.

Assisted-by: GPT-5.6 via Codex
@denialhaag denialhaag changed the title 🐛 Fix Jeff status return placement 🐛 Fix jeff status return placement Jul 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix Fix for something that isn't working MLIR Anything related to MLIR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant