🐛 Fix jeff status return placement#1939
Merged
Merged
Conversation
Assisted-by: GPT-5.6 via Codex
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
burgholzer
marked this pull request as ready for review
July 24, 2026 22:34
burgholzer
enabled auto-merge (squash)
July 24, 2026 22:34
burgholzer
added a commit
that referenced
this pull request
Jul 24, 2026
Integrate the Python CI and Jeff return-placement fixes from #1939. Assisted-by: GPT-5.6 via Codex
jeff status return placement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI text below 🤖
Summary
mlir/**changes as Python-relevant so binding-level tests and lint run on affected pull requests.Root cause
The entry-point restoration introduced in #1934 created the replacement
func.returnat the current rewriter insertion point, which remained near the start of the block after creating the zero status constant. Result-less Jeff programs therefore placed operations after the terminator and failed conversion.The original pull request did not expose this through Python because the shared change detector did not classify
mlir/**changes as Python-relevant, so all Python jobs were skipped.Impact
Serialized result-less Jeff programs can again be compiled through the Python
compile_programentry point. Future MLIR changes will exercise the Python bindings in pull-request CI.Validation
git diff --check: passed