Use ! in place of not keyword for Pilz and CHOMP planners#3217
Merged
Conversation
JafarAbdi
approved these changes
Jan 9, 2025
Member
|
Thanks! I replaced another usage of |
sea-bass
approved these changes
Jan 9, 2025
Contributor
sea-bass
left a comment
There was a problem hiding this comment.
Nice -- thank you!
Fixing the PR title then we can merge
Contributor
Author
|
Thanks for the super-fast feedback! |
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #3217 +/- ##
==========================================
+ Coverage 45.64% 45.65% +0.01%
==========================================
Files 714 714
Lines 62297 62299 +2
Branches 7529 7530 +1
==========================================
+ Hits 28432 28436 +4
+ Misses 33699 33696 -3
- Partials 166 167 +1 ☔ View full report in Codecov by Sentry. |
mergify Bot
pushed a commit
that referenced
this pull request
Jan 10, 2025
* pilz_industrial_motion_planner: Use ! in place of not keyword for consistency * Use ! in place of not keyword for chomp_planner.cpp --------- Co-authored-by: JafarAbdi <jafar.uruc@gmail.com> (cherry picked from commit 549a2ee)
mergify Bot
pushed a commit
that referenced
this pull request
Jan 10, 2025
* pilz_industrial_motion_planner: Use ! in place of not keyword for consistency * Use ! in place of not keyword for chomp_planner.cpp --------- Co-authored-by: JafarAbdi <jafar.uruc@gmail.com> (cherry picked from commit 549a2ee)
This was referenced Jan 10, 2025
sea-bass
pushed a commit
that referenced
this pull request
Jan 10, 2025
sea-bass
pushed a commit
that referenced
this pull request
Jan 10, 2025
sussybot5258
pushed a commit
to GreyCatAI/moveit2
that referenced
this pull request
Apr 19, 2025
* pilz_industrial_motion_planner: Use ! in place of not keyword for consistency * Use ! in place of not keyword for chomp_planner.cpp --------- Co-authored-by: JafarAbdi <jafar.uruc@gmail.com>
6 tasks
Markus-Simonsen
pushed a commit
to Markus-Simonsen/moveit2
that referenced
this pull request
Aug 12, 2025
* pilz_industrial_motion_planner: Use ! in place of not keyword for consistency * Use ! in place of not keyword for chomp_planner.cpp --------- Co-authored-by: JafarAbdi <jafar.uruc@gmail.com>
helen9975
pushed a commit
to personalrobotics/moveit2
that referenced
this pull request
Feb 17, 2026
* pilz_industrial_motion_planner: Use ! in place of not keyword for consistency * Use ! in place of not keyword for chomp_planner.cpp --------- Co-authored-by: JafarAbdi <jafar.uruc@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
While compiling this package on Windows (see RoboStack/ros-humble#241), the Windows compilation was failing as depending on the compilation options
notmay not be supported in MSVC depending on the compilation options.Anyhow, as everywhere else in the code
!is used, I think it make sense to be consistent and use!also here.Checklist