Use && in place of and keyword in action_based_controller_handle.hpp#3510
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3510 +/- ##
==========================================
+ Coverage 46.21% 46.22% +0.01%
==========================================
Files 720 720
Lines 62714 62713 -1
Branches 7592 7591 -1
==========================================
+ Hits 28979 28980 +1
+ Misses 33568 33567 -1
+ Partials 167 166 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rhaschke
approved these changes
Jun 22, 2025
Markus-Simonsen
pushed a commit
to Markus-Simonsen/moveit2
that referenced
this pull request
Aug 12, 2025
helen9975
pushed a commit
to personalrobotics/moveit2
that referenced
this pull request
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
While compiling this package on Windows (see RoboStack/ros-humble#241 for a similar issue), the Windows compilation was failing as depending on the compilation options
andmay not be supported in MSVC.Anyhow, as everywhere else in the code
&&is used, I think it make sense to be consistent and use&&also here.Similar to #3217 .
Checklist