Skip to content

Use && in place of and keyword in action_based_controller_handle.hpp#3510

Merged
rhaschke merged 1 commit into
moveit:mainfrom
traversaro:patch-17
Jun 22, 2025
Merged

Use && in place of and keyword in action_based_controller_handle.hpp#3510
rhaschke merged 1 commit into
moveit:mainfrom
traversaro:patch-17

Conversation

@traversaro
Copy link
Copy Markdown
Contributor

@traversaro traversaro commented Jun 22, 2025

Description

While compiling this package on Windows (see RoboStack/ros-humble#241 for a similar issue), the Windows compilation was failing as depending on the compilation options and may not be supported in MSVC.

Anyhow, as everywhere else in the code && is used, I think it make sense to be consistent and use && also here.

Similar to #3217 .

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • Extend the tutorials / documentation reference
  • Document API changes relevant to the user in the MIGRATION.md notes
  • Create tests, which fail without this PR reference
  • Include a screenshot if changing a GUI
  • While waiting for someone to review your request, please help review another open pull request to support the maintainers

@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 22, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 46.22%. Comparing base (6cb8644) to head (a60e07c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...troller_manager/action_based_controller_handle.hpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3510      +/-   ##
==========================================
+ Coverage   46.21%   46.22%   +0.01%     
==========================================
  Files         720      720              
  Lines       62714    62713       -1     
  Branches     7592     7591       -1     
==========================================
+ Hits        28979    28980       +1     
+ Misses      33568    33567       -1     
+ Partials      167      166       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rhaschke rhaschke merged commit 631e7ba into moveit:main Jun 22, 2025
8 of 10 checks passed
@github-project-automation github-project-automation Bot moved this to ✅ Done in MoveIt Jun 22, 2025
Markus-Simonsen pushed a commit to Markus-Simonsen/moveit2 that referenced this pull request Aug 12, 2025
helen9975 pushed a commit to personalrobotics/moveit2 that referenced this pull request Feb 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants