Deprecate autolink functionality to copy useWinUI3 flags from react-native.config.js into ExperimentalFeatures.props#14761
Closed
Deprecate autolink functionality to copy useWinUI3 flags from react-native.config.js into ExperimentalFeatures.props#14761
Conversation
… react-native.config.js Co-authored-by: anupriya13 <54227869+anupriya13@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Deprecate autolink functionality to copy flags from react-native.config.js into ExperimentalFeature.props.
Deprecate autolink functionality to copy useWinUI3 flags from react-native.config.js into ExperimentalFeatures.props
Jun 11, 2025
Contributor
|
@copilot run |
Contributor
Author
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Contributor
|
@copilot Completely remove the |
Co-authored-by: jonthysell <10852185+jonthysell@users.noreply.github.com>
Contributor
Author
I've completely removed the
The changes resulted in a net reduction of 260+ lines of code. The autolink functionality now focuses purely on generating autolink files for native modules without any XAML dialect management. Commit: 7ce01ee Warning Firewall rules blocked me from connecting to one or more addressesI tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Contributor
|
/azp run PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR removes the deprecated functionality in
ensureXAMLDialect()that alloweduseWinUI3values fromreact-native.config.jsto override values inExperimentalFeatures.props. This feature was confusing, unnecessary, and causing test failures.Background
The
ensureXAMLDialect()function previously had logic that:useWinUI3fromreact-native.config.jsExperimentalFeatures.propsThis behavior was problematic because:
Changes Made
Core Logic Changes
ensureXAMLDialect()function inautolinkWindows.ts:useWinUI3FromConfigvariable and related logicExperimentalFeatures.propsExperimentalFeatures.propsTest Updates
Removed failing tests in
autolink.test.ts:ensureXAMLDialect - useWinUI3=true in react-native.config.js, useWinUI3=false in ExperimentalFeatures.propsensureXAMLDialect - useWinUI3=false in react-native.config.js, useWinUI3=true in ExperimentalFeatures.propsRemoved broken test in
projectConfig.test.ts:Preserved Functionality
useWinUI3setting inreact-native.config.jsremains available for other uses (e.g., project generation)ExperimentalFeatures.propsvalues directlyImpact
useWinUI3usageTesting
The remaining tests verify that:
useWinUI3is not specified in config, the function usesExperimentalFeatures.propsvalues directlyUseWinUI3=trueandUseWinUI3=falsein project filesFixes #14601.