fix(new-arch): metro warning for Flyout/Popup#14817
Merged
chiaramooney merged 6 commits intomicrosoft:mainfrom Jul 3, 2025
Merged
fix(new-arch): metro warning for Flyout/Popup#14817chiaramooney merged 6 commits intomicrosoft:mainfrom
chiaramooney merged 6 commits intomicrosoft:mainfrom
Conversation
Contributor
|
Please run |
Contributor
Author
|
@acoates-ms sure thing, should it bump the prelease version if it is just a warning in this case? |
acoates-ms
approved these changes
Jun 30, 2025
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
jonthysell
approved these changes
Jul 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Why
While building an app in the New Architecture template, if you use either
<Flyout />or<Popup />you'll be met with the unsupported Fabric view red box. This error is displayed from RN core.Additionally, we can display a Metro warning to make the error more clear to the user - that they should be migrating to
<Modal />Resolves #14671
What
global.nativeFabricUIManagerconsole.warnin the contructors ofFlyoutandPopupScreenshots
Testing
Manually tested by editing
node_modules\react-native-windows\Libraries\Components\Flyout\Flyout.jsChangelog
Should this change be included in the release notes: No
Microsoft Reviewers: Open in CodeFlow