Skip to content

Wait for pod creation separately from readiness - #681

Open
dprotaso wants to merge 3 commits into
knative-extensions:mainfrom
dprotaso:fix/quickstart-pod-creation-wait
Open

dprotaso wants to merge 3 commits into
knative-extensions:mainfrom
dprotaso:fix/quickstart-pod-creation-wait

Conversation

@dprotaso

@dprotaso dprotaso commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

Problem

waitForPodsReady passes --for=create and --for=condition=Ready to one kubectl invocation. Since --for is a string flag, the second value overrides the first. Installation can still fail immediately when pods have not appeared yet.

Changes

  • Run creation and readiness waits separately, retaining the namespace, selector, and timeout.
  • Stop if creation fails and propagate readiness failures.
  • Test condition ordering and error propagation through one wait(condition) callback, without command factories, subprocesses, or external services.

Validation

  • go test -race ./...
  • golangci-lint run --new-from-rev=upstream/main ./... (0 issues)

Signed-off-by: Dave Protasowski <dprotaso@gmail.com>
@knative-prow

knative-prow Bot commented Nov 15, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow
knative-prow Bot requested review from dsimansk and psschwei November 15, 2026 05:21
@knative-prow knative-prow Bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 15, 2026
Signed-off-by: Dave Protasowski <dprotaso@gmail.com>
Signed-off-by: Dave Protasowski <dprotaso@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants