Skip to content

Target installation commands without changing the current context - #683

Open
dprotaso wants to merge 6 commits into
knative-extensions:mainfrom
dprotaso:fix/quickstart-cluster-context
Open

dprotaso wants to merge 6 commits into
knative-extensions:mainfrom
dprotaso:fix/quickstart-cluster-context

Conversation

@dprotaso

@dprotaso dprotaso commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

Problem

When an existing Kind cluster or Minikube profile is reused, quickstart's namespace checks and installation use the current kubeconfig context, which may point to an unrelated cluster.

Changes

  • Pass --context explicitly on every installation command, namespace check, and registry-hosting ConfigMap apply.
  • Carry the resolved cluster context in Installer, with Installer.kubectl constructing the commands. Remove the unused package-level installation wrappers.
  • Do not change the current context, preserving Minikube's passthrough --keep-context behavior.
  • Test default and explicit context arguments directly, without subprocesses or API fixtures.

Validation

Rebased on #685 and held until it lands. The PR still targets main, so its diff includes #685 until that dependency merges. #681 also overlaps the pod-wait helper and must be accounted for before unholding. No live-cluster validation was performed.

Signed-off-by: Dave Protasowski <dprotaso@gmail.com>
@knative-prow

knative-prow Bot commented Nov 15, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow
knative-prow Bot requested review from dsimansk and psschwei November 15, 2026 05:21
@knative-prow knative-prow Bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 15, 2026
Signed-off-by: Dave Protasowski <dprotaso@gmail.com>
@dprotaso dprotaso changed the title Select the requested cluster context before installing Knative Target installation commands without changing the current context Nov 15, 2026
Signed-off-by: Dave Protasowski <dprotaso@gmail.com>
Signed-off-by: Dave Protasowski <dprotaso@gmail.com>
Signed-off-by: Dave Protasowski <dprotaso@gmail.com>
Signed-off-by: Dave Protasowski <dprotaso@gmail.com>
@dprotaso

Copy link
Copy Markdown
Contributor Author

/hold

Rebased on #685. Hold until #685 has merged; #681 also overlaps the pod-wait helper and will need to be accounted for before unholding.

@dprotaso
dprotaso force-pushed the fix/quickstart-cluster-context branch from df43a07 to 3bf92d0 Compare November 15, 2026 05:50
@knative-prow knative-prow Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants