Repository navigation
Refactor of particle initialisation #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Carpenteri0
wants to merge
19
commits into
iterorganization:develop
Choose a base branch
from
Carpenteri0:feature/init-refactor
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
3ee0240
Refactored particle initialisation in kinetic_main, rejection functio…
Carpenteri0 22c299b
Updated stop clauses to be MPI_ABORT in particle initialiser routines
Carpenteri0 b0ae17a
Removed redundant num_re
Carpenteri0 75c9d1a
Safer mpi ierr handling in mod_initialise_particles
Carpenteri0 c760231
Added extra compatibility checks before initialising particles
Carpenteri0 6af9ba7
Fixed handling outside LCFS for analytical space pdf in particle init
Carpenteri0 88e3787
Updated initialiser subroutines to exepct spatial_pdf type rather tha…
Carpenteri0 94f538e
Added calculation of j_tor/R bounds for current_pdf
Carpenteri0 98d8740
Fixed a few typos/bugs
Carpenteri0 ede436e
Moved eval_rej_f into the rejection function module
Carpenteri0 2e311bb
Removed accidentally commited files
Carpenteri0 e654e6e
Removed redundant comment
Carpenteri0 2bc631a
Fixed seed_particles example
Carpenteri0 2d102f1
Merge branch 'develop' into feature/init-refactor
Carpenteri0 1d87554
Fixed broken use statements, mostly mod_initialise_particles -> initi…
Carpenteri0 5715448
Merge branch 'develop' into feature/init-refactor
Carpenteri0 65df06e
Added use mod_interp to particle example files - should fix compile e…
Carpenteri0 6a75d2e
Merge branch 'develop' into feature/init-refactor
Carpenteri0 1aae890
Addressing Edo's comments. Namely adding default branch to init_funct…
Carpenteri0 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Old RE inputs that still set num_re will now fail at namelist read with a generic error. It would be worth a line pointing to n_particles_total
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I changed num_re in the only .md where it turned up, and the reg_tests. Hopefully any RE people already using kinetic_main will notice this change, where else would you suggest leaving a comment?