Skip to content

Refactor of particle initialisation - #33

Open
Carpenteri0 wants to merge 15 commits into
iterorganization:developfrom
Carpenteri0:feature/init-refactor
Open

Carpenteri0 wants to merge 15 commits into
iterorganization:developfrom
Carpenteri0:feature/init-refactor

Conversation

@Carpenteri0

Copy link
Copy Markdown
Collaborator

Mostly backend aesthetic changes. Main change is rejection functions have their own module, with type definitions, a few helper subroutines, and all existing rej funcs that were previously in ~3 other modules. Other smaller changes :

  • Removed num_re param. Now rep and epf both use n_particles_total to set weights
  • Reduced code duplication in 3 initialiser subroutines - evaluation of rej f now has its own subroutine in the rej f module
  • Initialiser function is checked against particle type rather than coupling scheme - more flexibility / reuseability in initialiser subroutines between coupling schemes.
  • Removed hard coded current limits in current_pdf - now finds these limits once per run before initialisation
  • Also added Timo's "experimental" method of initialising particles in mod_import_experimental_dist (which is now moved to particles/initialisers/)

@N-Schwarz

Copy link
Copy Markdown
Collaborator

Hi @Carpenteri0 , you should be able to add reviewers to the pull request once it's ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants