Refactor of particle initialisation - #33
Open
Carpenteri0 wants to merge 15 commits into
Open
Carpenteri0 wants to merge 15 commits into
Carpenteri0 wants to merge 15 commits into
Conversation
…ns have their own module and bundling type, this commit compiles
…n rej function and variables seperately, evaluating the rej_f has its own subroutine now too
Collaborator
|
Hi @Carpenteri0 , you should be able to add reviewers to the pull request once it's ready. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly backend aesthetic changes. Main change is rejection functions have their own module, with type definitions, a few helper subroutines, and all existing rej funcs that were previously in ~3 other modules. Other smaller changes :