Skip to content

[UR][L0] Fix ZES_FAN_SPEED_UNITS_PERCENT query on devices with unreadable fans #22813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ldorau wants to merge 1 commit into from
Closed

[UR][L0] Fix ZES_FAN_SPEED_UNITS_PERCENT query on devices with unreadable fans #22813

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 24 additions & 7 deletions unified-runtime/source/adapters/level_zero/common/device.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1457,20 +1457,37 @@ ur_result_t urDeviceGetInfo(
if (FanCount == 0)
return UR_RESULT_ERROR_UNSUPPORTED_ENUMERATION;

if (!ParamValue) {
// If ParamValue is nullptr, then we are only interested in the size of
// the value.
return ReturnValue(int32_t{0});
}

std::vector<zes_fan_handle_t> ZeFanHandles(FanCount);
ZE2UR_CALL(zesDeviceEnumFans, (ZesDevice, &FanCount, ZeFanHandles.data()));

// Some devices enumerate fan handles that don't actually support
// reporting their state (observed on Arc(TM) B-series GPUs), so probe
// every fan and only treat the query as supported if at least one of
// them can report a speed. Do this before servicing the size-only query
// so that UNSUPPORTED_ENUMERATION is returned consistently regardless of
// whether the caller is asking for the size or the value.
int32_t Speed = -1;
bool AnyFanSupported = false;
for (auto Fan : ZeFanHandles) {
int32_t CurSpeed;
ZE2UR_CALL(zesFanGetState, (Fan, ZES_FAN_SPEED_UNITS_PERCENT, &CurSpeed));
auto ZeResult = ZE_CALL_NOCHECK(
zesFanGetState, (Fan, ZES_FAN_SPEED_UNITS_PERCENT, &CurSpeed));
if (ZeResult == ZE_RESULT_ERROR_UNSUPPORTED_FEATURE)
continue;
if (ZeResult != ZE_RESULT_SUCCESS)
return ze2urResult(ZeResult);
AnyFanSupported = true;
Speed = std::max(Speed, CurSpeed);
}
if (!AnyFanSupported)
return UR_RESULT_ERROR_UNSUPPORTED_ENUMERATION;

if (!ParamValue) {
// If ParamValue is nullptr, then we are only interested in the size of
// the value.
return ReturnValue(int32_t{0});
}

return ReturnValue(Speed);
}
case UR_DEVICE_INFO_MIN_POWER_LIMIT:
Expand Down
Loading