[UR][L0] Fix ZES_FAN_SPEED_UNITS_PERCENT query on devices with unreadable fans - #22813
Closed
ldorau wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
Please review @intel/unified-runtime-reviewers-level-zero |
pbalcer
reviewed
Jul 30, 2026
pbalcer
left a comment
pbalcer
left a comment
Contributor
There was a problem hiding this comment.
why is this failing now? was the driver updated?
Contributor
Author
|
…e fans Some devices (observed on Arc(TM) B-series GPUs) enumerate fan handles via zesDeviceEnumFans, but zesFanGetState fails with ZE_RESULT_ERROR_UNSUPPORTED_FEATURE when trying to read their state. Previously this caused urDeviceGetInfo(UR_DEVICE_INFO_FAN_SPEED) to succeed for the size-only query but fail for the actual value query, which broke the urDeviceGetInfoTest.SuccessFanSpeed conformance test. Probe every enumerated fan for actual read support and return UR_RESULT_ERROR_UNSUPPORTED_ENUMERATION consistently (for both the size and value queries) when none of the fans can report their state, matching the existing pattern used for UR_DEVICE_INFO_MAX_POWER_LIMIT. Fixes: intel#22812 Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>
Contributor
We should figure out what changed in the driver, and possibly report an issue there. |
ldorau
marked this pull request as draft
July 30, 2026 13:58
ldorau
changed the title
Contributor
Author
OK, replaced with #22837 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some devices (observed on Arc(TM) B-series GPUs) enumerate fan handles
via zesDeviceEnumFans, but zesFanGetState fails with
ZE_RESULT_ERROR_UNSUPPORTED_FEATURE when trying to read their state.
Previously this caused urDeviceGetInfo(UR_DEVICE_INFO_FAN_SPEED) to
succeed for the size-only query but fail for the actual value query,
which broke the urDeviceGetInfoTest.SuccessFanSpeed conformance test.
Probe every enumerated fan for actual read support and return
UR_RESULT_ERROR_UNSUPPORTED_ENUMERATION consistently (for both the
size and value queries) when none of the fans can report their state,
matching the existing pattern used for UR_DEVICE_INFO_MAX_POWER_LIMIT.
Fixes: #22812