Skip to content

generate sql and execute #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
muthukumaran25 wants to merge 8 commits into
base: main
Choose a base branch
from
Open

generate sql and execute #113

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4905cec
Create generate_sql_and_exec.ipynb
muthukumaran25 Sep 25, 2024
8b4bb1d
Update generate_sql_and_exec.ipynb
muthukumaran25 Sep 25, 2024
ae9c518
Update generate_sql_and_exec.ipynb
muthukumaran25 Oct 9, 2024
c487446
Update vanilla_notebooks.txt
muthukumaran25 Oct 9, 2024
6650612
Update vanilla_workflow.yaml
muthukumaran25 Oct 9, 2024
611f1b8
Update generate_sql_and_exec.ipynb
muthukumaran25 Oct 9, 2024
ff06cd5
Update generate_sql_and_exec.ipynb
muthukumaran25 Oct 9, 2024
622116f
Update generate_sql_and_exec.ipynb
muthukumaran25 Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/notebook_lists/vanilla_notebooks.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,4 @@ recipes/Guard-Rails/HAP.ipynb
recipes/Auto_Documentation/Auto_Documentation.ipynb
recipes/Text_to_Shell_Exec/Text_to_Shell_Exec.ipynb
recipes/Text_to_SQL/Text_to_SQL.ipynb
recipes/generate_sql_and_execute/generate_sql_and_exec.ipynb
Copy link
Member

@bjhargrave bjhargrave Dec 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recipes in this file are tested during the CI build. I am not sure this recipe can be tested since it seems to include a number of manual steps instead of executable cells. If that is the case, then it should not be listed in this file.

It should however be mentioned in the readme like other recipes are.

3 changes: 2 additions & 1 deletion .github/workflows/vanilla_workflow.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ on:
- 'recipes/Text_to_Shell/Text_to_Shell.ipynb'
- 'recipes/Text_to_Shell_Exec/Text_to_Shell_Exec.ipynb'
- 'recipes/Text_to_SQL/Text_to_SQL.ipynb'
- 'recipes/generate_sql_and_execute/generate_sql_and_exec.ipynb'
Copy link
Member

@bjhargrave bjhargrave Dec 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file no longer exists and you don't need to modify the workflows anymore for a new recipe.

pull_request:
branches:
- main
Expand All @@ -21,7 +22,7 @@ on:
- 'recipes/Text_to_Shell/Text_to_Shell.ipynb'
- 'recipes/Text_to_Shell_Exec/Text_to_Shell_Exec.ipynb'
- 'recipes/Text_to_SQL/Text_to_SQL.ipynb'

- 'recipes/generate_sql_and_execute/generate_sql_and_exec.ipynb'

jobs:
test-vanilla-notebooks:
Expand Down
Loading