generate sql and execute #113
Conversation
rawkintrevo
left a comment
rawkintrevo
left a comment
There was a problem hiding this comment.
Please remove images from the workbook (move to seperate files in the PR if they are needed). Then please rebase on main and add recipes/generate_sql_and_execute/generate_sql_and_exec.ipynb
to the appropriate file in .git/workflows
| ] | ||
| }, | ||
| { | ||
| "attachments": { |
There was a problem hiding this comment.
If you need an image in your workbook, please include it as a seperate file, not inline in the notebook.
There was a problem hiding this comment.
Done. Removed the images and added to .github/workflows and .github/notebook_lists
muthukumaran25
force-pushed
the
muthu2509
branch
from
e786f0b to
4ae6b44
Compare
Signed-off-by: Muthukumaran <[email protected]>
Signed-off-by: Muthukumaran <[email protected]>
Signed-off-by: Muthukumaran <[email protected]>
Signed-off-by: Muthukumaran <[email protected]>
Signed-off-by: Muthukumaran <[email protected]>
Signed-off-by: Muthukumaran <[email protected]>
Signed-off-by: Muthukumaran <[email protected]>
Signed-off-by: Muthukumaran <[email protected]>
muthukumaran25
force-pushed
the
muthu2509
branch
from
2ccd3eb to
622116f
Compare
|
@rawkintrevo I have made the requested changes. Am i missing anything for the approval and merge? Please let me know. |
|
hi @muthukumaran25 the testing has radically changed since my last comments. You'll want to work with @bjhargrave going forward, replacing myself with him as a reviewer |
rawkintrevo
requested review from
bjhargrave
and removed request for
rawkintrevo
bjhargrave
left a comment
bjhargrave
left a comment
There was a problem hiding this comment.
Please also rebase on the tip of main.
| - 'recipes/Text_to_Shell/Text_to_Shell.ipynb' | ||
| - 'recipes/Text_to_Shell_Exec/Text_to_Shell_Exec.ipynb' | ||
| - 'recipes/Text_to_SQL/Text_to_SQL.ipynb' | ||
| - 'recipes/generate_sql_and_execute/generate_sql_and_exec.ipynb' |
There was a problem hiding this comment.
This file no longer exists and you don't need to modify the workflows anymore for a new recipe.
| recipes/Auto_Documentation/Auto_Documentation.ipynb | ||
| recipes/Text_to_Shell_Exec/Text_to_Shell_Exec.ipynb | ||
| recipes/Text_to_SQL/Text_to_SQL.ipynb | ||
| recipes/generate_sql_and_execute/generate_sql_and_exec.ipynb |
There was a problem hiding this comment.
Recipes in this file are tested during the CI build. I am not sure this recipe can be tested since it seems to include a number of manual steps instead of executable cells. If that is the case, then it should not be listed in this file.
It should however be mentioned in the readme like other recipes are.
| "db2\": {\n", | ||
| " \"authentication\": {\n", | ||
| " \"method\": \"direct\",\n", | ||
| " \"password\": \"maDVHz4oUqmVE_mod\",\n", |
There was a problem hiding this comment.
This seems to be a real username and password rather than a placeholder?
| "metadata": {}, | ||
| "outputs": [], | ||
| "source": [ | ||
| "!pip install git+https://github.com/ibm-granite-community/granite-kitchen" |
There was a problem hiding this comment.
| "!pip install git+https://github.com/ibm-granite-community/granite-kitchen" | |
| "!pip install git+https://github.com/ibm-granite-community/utils.git" |
We are using utils now. You may need to include other python packages needed by this recipe here like langchain_community, replicate, etc.
3 participants
No description provided.