Skip to content

test(ecdh): enable P-521 tests on Safari #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
harrshita123 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

test(ecdh): enable P-521 tests on Safari #352

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 1 addition & 11 deletions lib/src/impl_interface/impl_interface.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,17 +40,7 @@ typedef KeyPair<T, S> = ({T privateKey, S publicKey});
///
/// > [!NOTE]
/// > Additional values may be added to this enum in the future.
enum EllipticCurve {
p256,
p384,

///
///
/// P-521 is **not supported on Safari**, see [bug 216755 (bugs.webkit.org)][1].
///
/// [1]: https://bugs.webkit.org/show_bug.cgi?id=216755
p521,
}
enum EllipticCurve { p256, p384, p521 }

/// Thrown when an operation failed for an operation-specific reason.
final class OperationError extends Error {
Expand Down
5 changes: 1 addition & 4 deletions lib/src/testing/webcrypto/ecdh.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
import 'package:webcrypto/webcrypto.dart';
import '../utils/utils.dart';
import '../utils/testrunner.dart';
import '../utils/detected_runtime.dart';

final runner = TestRunner.asymmetric<EcdhPrivateKey, EcdhPublicKey>(
algorithm: 'ECDH',
Expand Down Expand Up @@ -170,9 +169,7 @@ final _testData = [
"deriveParams": {},
},

/// Safari and WebKit on Mac (with CommonCrypto) does not support P-521, see:
/// https://bugs.webkit.org/show_bug.cgi?id=216755
...(nullOnSafari(_testDataWithP521) ?? <Map>[]),
..._testDataWithP521,

// TODO: generate on firefox, once the import/export pkcs8 has been figured out
];
Expand Down
Loading