Skip to content

test(ecdh): enable P-521 tests on Safari - #352

Open
harrshita123 wants to merge 1 commit into
google:masterfrom
harrshita123:test/safari-p521
Open

test(ecdh): enable P-521 tests on Safari#352
harrshita123 wants to merge 1 commit into
google:masterfrom
harrshita123:test/safari-p521

Conversation

@harrshita123

Copy link
Copy Markdown
Contributor

Summary

  • enable the existing P-521 ECDH vectors when the test suite runs on Safari
  • remove the obsolete documentation claiming that Safari does not support P-521
  • remove the runtime-detection import that is no longer needed by the ECDH tests

Safari now supports P-521, so excluding these vectors leaves a supported path untested. The existing vectors already cover key import and export across raw, SPKI, PKCS8, and JWK formats, as well as 528-bit key derivation.

Closes #129.

Validation

  • dart analyze --fatal-warnings .
  • full VM test suite (1,448 passed; 1 platform-specific skip)
  • P-521 ECDH tests on Safari 26.5.2 with Dart2JS (41 passed)
  • P-521 ECDH tests on Chrome with Dart2JS and Dart2Wasm (82 passed)

@harrshita123
harrshita123 marked this pull request as ready for review July 31, 2026 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tests if P-521 works on Safari

1 participant