fix(aci): prevent invalid custom resolve thresholds #104561
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
mifu67
approved these changes
Dec 8, 2025
scttcper
approved these changes
Dec 8, 2025
ryan953
pushed a commit
that referenced
this pull request
Dec 9, 2025
Fixed resolution validation so that we compare against the medium threshold number if it exists, and the high threshold if not. Previously we were only checking against the high threshold. New: <img width="723" height="395" alt="Screenshot 2025-12-08 at 3 20 00 PM" src="https://github.com/user-attachments/assets/ea8c4382-22b4-4822-95b0-838a3d1dcd74" /> Also fixed a bug where the medium threshold direction was not changing when the high direction was changed by adding a `key` to the DirectionField to force a rerender (lmk if there are better solutions) Bug: <img width="519" height="162" alt="Screenshot 2025-12-08 at 3 23 49 PM" src="https://github.com/user-attachments/assets/66c6b4e4-c855-47fd-8ad1-9ac5c99ab0d4" />
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed resolution validation so that we compare against the medium threshold number if it exists, and the high threshold if not. Previously we were only checking against the high threshold.
New:
Also fixed a bug where the medium threshold direction was not changing when the high direction was changed by adding a
keyto the DirectionField to force a rerender (lmk if there are better solutions)Bug:
