Commit c827797
authored
fix(aci): prevent invalid custom resolve thresholds (#104561)
Fixed resolution validation so that we compare against the medium
threshold number if it exists, and the high threshold if not. Previously
we were only checking against the high threshold.
New:
<img width="723" height="395" alt="Screenshot 2025-12-08 at 3 20 00 PM"
src="https://github.com/user-attachments/assets/ea8c4382-22b4-4822-95b0-838a3d1dcd74"
/>
Also fixed a bug where the medium threshold direction was not changing
when the high direction was changed by adding a `key` to the
DirectionField to force a rerender (lmk if there are better solutions)
Bug:
<img width="519" height="162" alt="Screenshot 2025-12-08 at 3 23 49 PM"
src="https://github.com/user-attachments/assets/66c6b4e4-c855-47fd-8ad1-9ac5c99ab0d4"
/>1 parent 895ad88 commit c827797
File tree
2 files changed
+14
-4
lines changed- static/app/views/detectors/components/forms/metric
2 files changed
+14
-4
lines changedLines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
255 | 255 | | |
256 | 256 | | |
257 | 257 | | |
| 258 | + | |
258 | 259 | | |
259 | 260 | | |
260 | 261 | | |
261 | 262 | | |
262 | 263 | | |
263 | 264 | | |
264 | | - | |
265 | 265 | | |
266 | 266 | | |
267 | 267 | | |
| |||
Lines changed: 13 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
31 | 31 | | |
32 | 32 | | |
33 | 33 | | |
34 | | - | |
35 | | - | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
36 | 46 | | |
37 | 47 | | |
38 | 48 | | |
39 | 49 | | |
40 | | - | |
| 50 | + | |
41 | 51 | | |
42 | 52 | | |
43 | 53 | | |
| |||
0 commit comments