Skip to content

fix: Lifetime period end to end in the desktop app, compact menubar labels #781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iamtoruk merged 1 commit into from
Jul 20, 2026
+8 −5
Merged

fix: Lifetime period end to end in the desktop app, compact menubar labels #781

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/electron/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ function configSourceArgs(source: string | null): string[] {
// Renderer-supplied strings become argv, so reject anything that could smuggle a
// flag or shell metacharacter before it reaches the CLI. Thrown from the argv
// builders, these surface through the same error envelope as any CliError.
const PERIODS = new Set(['today', 'week', '30days', 'month', 'all'])
const PERIODS = new Set(['today', 'week', '30days', 'month', 'all', 'lifetime'])
function vPeriod(period: string): string {
if (!PERIODS.has(period)) throw new CliError('bad-args', 'invalid period')
return period
Expand Down
11 changes: 7 additions & 4 deletions mac/Sources/CodeBurnMenubar/AppStore.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1502,12 +1502,15 @@ enum InsightMode: String, CaseIterable, Identifiable {
}

enum Period: String, CaseIterable, Identifiable {
// Compact labels: six segments plus the calendar button share one narrow
// popover row, so the longer names ("6 Months", "Lifetime") wrapped.
// Matches the desktop app's strip (Today / 7D / 30D / Month / 6M / Life).
case today = "Today"
case sevenDays = "7 Days"
case thirtyDays = "30 Days"
case sevenDays = "7D"
case thirtyDays = "30D"
case month = "Month"
case all = "6 Months"
case lifetime = "Lifetime"
case all = "6M"
case lifetime = "Life"

var id: String { rawValue }

Expand Down