fix: Lifetime period end to end in the desktop app, compact menubar labels#781
Merged
Conversation
The desktop app's Life tab failed with 'invalid period': the renderer and CLI both learned lifetime, but the electron IPC allowlist between them did not. The menubar's period row also overflowed once Lifetime joined it; labels compact to the desktop strip's forms (7D, 30D, 6M, Life). Period selection is not persisted by raw value, so the label change is safe. Follow-up worth doing: derive the IPC allowlist from the renderer's period module so a new period cannot miss one layer of three again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From live 0.9.19 screenshots: the desktop Life tab errored with invalid period because the electron IPC allowlist (app/electron/main.ts PERIODS) never learned lifetime even though the renderer and CLI both did; and the menubar period row wrapped once Lifetime joined (6 Months broke onto two lines). The allowlist gains lifetime; menubar labels compact to Today / 7D / 30D / Month / 6M / Life, matching the desktop strip. Selection is not persisted by raw value. Swift 113 tests and app 413 tests green. Suggested follow-up in the commit: derive the allowlist from the renderer's period module so three layers cannot drift again.