Organize Appearance and Interface settings - #4241
Merged
ymichael merged 2 commits intoSep 24, 2026
Merged
Conversation
ymichael
deleted the
bb/move-options-above-sidebar-footer-thr_75bvfeeyxh
branch
September 24, 2026 18:08
ymichael
added a commit
that referenced
this pull request
Sep 24, 2026
## Human comments ## What was wrong The Interface card introduced in #4241 renders its rows in source order. Header and the code renderer controls were placed before Sidebar and Navigation, so the visible order differed from the requested sequence. ## What changed - Render Sidebar and Navigation before Header, Source code, and Diffs; Sidebar footer remains last. - Delete the dedicated Appearance layout test as requested. No wire, SDK, CLI, or configuration contract changed. ## How you verified - `pnpm exec turbo run test --filter=@bb/app -- src/views/SettingsView.palette-preview.test.tsx src/components/plugin/PluginSidebarFooterItems.test.tsx` — 16 passed. - `pnpm exec turbo run lint typecheck --filter=@bb/app` — passed; lint had zero errors and 201 existing warnings. - `pnpm start:worktree --dryrun` — passed, then started the production worktree app at `504ef46d0befd05729a95cb2d6125baba32225ab`. - In the real app with a temporary plugin fixture, verified Sidebar → Navigation → Header → Source code → Diffs → Sidebar footer on Settings → Appearance. - [Live review page](https://ymichael--21547.getbb.app/settings/appearance) requires the owner's BB Connect login. > AGENT GENERATED
albrand
pushed a commit
to albrand/bb
that referenced
this pull request
Sep 24, 2026
Resolved conflicts: - plugins/environment-project-checkout/server.ts: keep the fork's removal of retireGraceMs: null (retire unmanaged checkouts) and add upstream's experimental_existingPath (get-bb#4187). - apps/app/src/views/SettingsView.tsx: take upstream's reorganized settings (get-bb#4241, get-bb#4275) and re-port the fork's Content width setting. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Human comments
What was wrong
Appearance placed sidebar provider choices ahead of Theme and Palette and mixed interface controls with appearance choices in one card. The order did not reflect how people use the page, and Sidebar footer customization sat among the appearance controls.
What changed
How you verified
pnpm exec turbo run test --filter=@bb/app -- src/views/SettingsView.appearance-layout.test.tsx src/views/SettingsView.palette-preview.test.tsx src/components/plugin/PluginSidebarFooterItems.test.tsx— 17 passed.pnpm exec turbo run lint typecheck --filter=@bb/app— passed; lint reported 0 errors and 200 warnings outside this change.pnpm start:worktree --dryrun— passed, then started the production worktree app at commit05d063e736018f9f2bac4e2200a72359f84341cc.Final GitHub checks for
05d063e736018f9f2bac4e2200a72359f84341cc: 16 passed, 2 skipped, 0 failed.No related issue was found.