Skip to content

Reorder Interface settings - #4275

Merged
ymichael merged 1 commit into
mainfrom
bb/reorder-interface-settings
Sep 24, 2026
Merged

ymichael merged 1 commit into
mainfrom
bb/reorder-interface-settings

Conversation

@ymichael

@ymichael ymichael commented Sep 24, 2026 •

Copy link
Copy Markdown
Collaborator

Human comments

What was wrong

The Interface card introduced in #4241 renders its rows in source order. Header and the code renderer controls were placed before Sidebar and Navigation, so the visible order differed from the requested sequence.

What changed

  • Render Sidebar and Navigation before Header, Source code, and Diffs; Sidebar footer remains last.
  • Delete the dedicated Appearance layout test as requested. No wire, SDK, CLI, or configuration contract changed.

How you verified

  • pnpm exec turbo run test --filter=@bb/app -- src/views/SettingsView.palette-preview.test.tsx src/components/plugin/PluginSidebarFooterItems.test.tsx — 16 passed.
  • pnpm exec turbo run lint typecheck --filter=@bb/app — passed; lint had zero errors and 201 existing warnings.
  • pnpm start:worktree --dryrun — passed, then started the production worktree app at 504ef46d0befd05729a95cb2d6125baba32225ab.
  • In the real app with a temporary plugin fixture, verified Sidebar → Navigation → Header → Source code → Diffs → Sidebar footer on Settings → Appearance.
  • Live review page requires the owner's BB Connect login.

Final GitHub CI: 16 passed, 2 skipped, 0 failed. The app-3 shard passed on rerun after an unrelated NavigationPlugin.test.tsx assertion failed in the initial run; its 51 tests also passed locally.

AGENT GENERATED

@ymichael
ymichael merged commit 08b27c0 into main Sep 24, 2026
29 of 30 checks passed
@ymichael
ymichael deleted the bb/reorder-interface-settings branch September 24, 2026 18:22
albrand pushed a commit to albrand/bb that referenced this pull request Sep 24, 2026
Resolved conflicts:
- plugins/environment-project-checkout/server.ts: keep the fork's removal of
  retireGraceMs: null (retire unmanaged checkouts) and add upstream's
  experimental_existingPath (get-bb#4187).
- apps/app/src/views/SettingsView.tsx: take upstream's reorganized settings
  (get-bb#4241, get-bb#4275) and re-port the fork's Content width setting.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant