Allow editing by fields and set fields value from general fields settings#10524
Open
Gaetanbrl wants to merge 3 commits intogeosolutions-it:masterfrom
Open
Allow editing by fields and set fields value from general fields settings#10524Gaetanbrl wants to merge 3 commits intogeosolutions-it:masterfrom
Gaetanbrl wants to merge 3 commits intogeosolutions-it:masterfrom
Conversation
Gaetanbrl
force-pushed
the
g2f-field-editable-autovalue
branch
from
b621a17 to
6d110a8
Compare
1 task
Gaetanbrl
force-pushed
the
g2f-field-editable-autovalue
branch
from
6d110a8 to
8939de4
Compare
Contributor
Author
|
The source branch is now rebase / align with master (8e2d443) |
Gaetanbrl
force-pushed
the
g2f-field-editable-autovalue
branch
from
8939de4 to
cb118cd
Compare
6 tasks
Gaetanbrl
changed the title
Fix karma Toolbar test fix linter
Gaetanbrl
force-pushed
the
g2f-field-editable-autovalue
branch
from
2e885a1 to
bdb8f0e
Compare
5 tasks
This was
linked to
issues
Nov 8, 2024
MV88
requested changes
Feb 28, 2025
| setShowPopoverSync(getApi().getItem("showPopoverSync") !== null && pluginCfg?.showPopoverSync ? getApi().getItem("showPopoverSync") === "true" : pluginCfg?.showPopoverSync); | ||
| } | ||
| }, [props.mode]); | ||
| // const canEditGeometry = props.isEditingAllowed && |
Contributor
There was a problem hiding this comment.
remove comments
Suggested change
| // const canEditGeometry = props.isEditingAllowed && |
| const layer = getLayerById(store.getState(), selectedLayerIdSelector(store.getState())); | ||
| // force value from fields | ||
| layer.fields.filter(f => f.value && f.source).forEach(f => { | ||
| updated[f.name] = f.value; |
Contributor
There was a problem hiding this comment.
I wouldn't manipulate and input parameter, rather create a copy of that parameter and update a different one
| return Rx.Observable.of(drawSupportReset()); | ||
| }); | ||
|
|
||
| export const handleFeatureChanges = (action$, store) => action$.ofType(CREATE_NEW_FEATURE, GRID_ROW_UPDATE) |
Comment on lines
+24
to
+32
| fields?.forEach?.((field) => { | ||
| if (field.source) { | ||
| field.value = get(userInfos, field.source) || find(userInfos.attribute, ["name", field.source])?.value; | ||
| field.editable = false; | ||
| } else if (!field.source && field.value) { | ||
| field.value = null; | ||
| field.editable = null; | ||
| } | ||
| }); |
Contributor
There was a problem hiding this comment.
I think is not ideal to manipulate params like this for a question of Immutability
better to edit a new object and avoid mutation to match generic code style of mapstore. especially for reducers
| })(state); | ||
| return (canEdit || isAllowed) && !isCesium(state); | ||
| }; | ||
| // geometry can be editing according to geom field setting |
Contributor
There was a problem hiding this comment.
- transform this comment in a jsdoc
- add a test for this selector
| showTitleTooltip: !!option?.description, | ||
| resizable, | ||
| editable, | ||
| editable: field?.editable === false ? false : editable, |
| updated | ||
| }; | ||
| } | ||
| export function gridRowUpdate(features, updated) { |
Contributor
There was a problem hiding this comment.
- add jsdoc
- this needs a unit test
| }, []); | ||
|
|
||
| const onChange = (name, attribute, value) => { | ||
| const onChange = (name, attribute, value, isGeometryType = false) => { |
Contributor
There was a problem hiding this comment.
where this 4th parameter being used?
Contributor
Author
|
Thanks for this review @MV88 . |
Member
|
@Gaetanbrl I'm sorry, this PR is quite old. Do you have plans to re-handle this according to our review above? Otherwise, I would like to close the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Documentation
Nothing to document without corresponding UI (need fields settings UI enhancement).
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
Issue
What is the current behavior?
This is new behavior. See issue to get more details.
#10523
#9849
#10658
What is the new behavior?
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information