fix(admin): let the add-app dialog accept a typed branch - #378
Merged
tanmoysrt merged 1 commit intoAug 27, 2026
Merged
Conversation
This was referenced Aug 10, 2026
mihir-kandoi
force-pushed
the
fix/add-app-dialog-custom-branch
branch
from
August 25, 2026 13:52
48d1fbf to
d08ab84
Compare
mihir-kandoi
force-pushed
the
fix/add-app-dialog-custom-branch
branch
from
August 25, 2026 14:25
d08ab84 to
70a8586
Compare
tanmoysrt
force-pushed
the
fix/add-app-dialog-custom-branch
branch
from
August 26, 2026 08:32
70a8586 to
2d267e8
Compare
mihir-kandoi
force-pushed
the
fix/add-app-dialog-custom-branch
branch
2 times, most recently
from
August 26, 2026 09:46
303b2f7 to
4533363
Compare
mihir-kandoi
force-pushed
the
fix/add-app-dialog-custom-branch
branch
2 times, most recently
from
August 26, 2026 10:01
982bdd2 to
3919e92
Compare
tanmoysrt
force-pushed
the
fix/add-app-dialog-custom-branch
branch
from
August 26, 2026 10:05
3919e92 to
37187e2
Compare
tanmoysrt
force-pushed
the
fix/add-app-dialog-custom-branch
branch
from
August 27, 2026 10:41
37187e2 to
92a5035
Compare
The manual-URL branch picker passed allowCustomValue, which does not exist in frappe-ui 1.0.0-beta.34 - it fell through to the input as an inert DOM attribute, so a typed branch never committed even though the empty state promised it would. Use the shared branchComboboxOptions typed-branch row instead, in button trigger mode like the wizard. The connected-GitHub picker keeps its list-only options: its branches come from the authenticated listing, and it never offered free text.
tanmoysrt
force-pushed
the
fix/add-app-dialog-custom-branch
branch
from
August 27, 2026 12:16
92a5035 to
604498f
Compare
Member
|
@greptile review |
Contributor
Confidence Score: 4/5The PR appears safe to merge, with the non-blocking request to cover the dialog’s typed-branch interaction. The implementation mirrors an existing branch-picker pattern, but helper-only tests do not protect the newly changed component wiring. Files Needing Attention: admin/frontend/dashboard/src/components/apps/AddAppFromGithubDialog.vue Prompt To Fix All With AI### Issue 1
admin/frontend/dashboard/src/components/apps/AddAppFromGithubDialog.vue:216
**Untested dialog integration**
Add a regression test that exercises typing and selecting a custom branch through this dialog; the existing helper-only tests do not cover the changed `trigger`, slot, and `v-model` integration, so that user flow can regress while the tests remain green.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Reviews (1): Last reviewed commit: "fix(admin): let the add-app dialog accep..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #377.
The add-app dialog's manual-URL branch picker passes
allowCustomValue, which doesn't exist in frappe-ui 1.0.0-beta.34 — it lands on the<input>as an inert DOM attribute, so the promised "Type one to use it" flow silently never commits. This extracts #377's pick-or-type options into a sharedbranchComboboxOptionshelper, points both the wizard and the dialog at it, and switches the dialog's manual picker to the same button-trigger custom-row pattern. The connected-GitHub picker stays list-only, as before.Typed branches still go through
resolveApp, so an invalid name can't be submitted. Unit tests cover the helper via the existingnode --testharness;npm run buildpasses.