fix(apps): refuse to reinstall an app from a different branch - #381
Open
mihir-kandoi wants to merge 2 commits into
Open
fix(apps): refuse to reinstall an app from a different branch#381mihir-kandoi wants to merge 2 commits into
mihir-kandoi wants to merge 2 commits into
Conversation
App.install short-circuits when the app is already in the bench, which silently discarded an explicitly requested branch: importing erpnext@version-16-hotfix over the existing version-16 clone reported success while the site got version-16. A bench holds one checkout per app, so the install now fails loudly, naming both branches. GetAppCommand also stops defaulting an unspecified branch to 'main'. clone() already resolves the remote's real default, and the injected 'main' would read as explicit intent to the new guard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
App.installshort-circuits when the app already exists in the bench — and silently discarded an explicitly requested branch while doing so. Importingerpnext@version-16-hotfixover an existingversion-16clone reported success while the site gotversion-16. Since a bench holds one checkout per app, the install now fails loudly naming both branches instead of pretending.Also removes
GetAppCommand'sor "main"branch default:clone()already resolves the remote's real default branch, and the injected "main" would look like explicit intent to the new guard.Related:
SwitchBranchTaskexists and is the right tool for moving an installed app to another branch, but nothing wires it to the CLI or admin API yet — follow-up. Independent of #377/#378/#380.