Skip to content

fix(salary-slip): show loan repayment in salary slip print formats - #5100

Closed
nareshkannasln wants to merge 2 commits into
frappe:developfrom
aerele:salary-slip-loan-repayment-print
Closed

nareshkannasln wants to merge 2 commits into
frappe:developfrom
aerele:salary-slip-loan-repayment-print

Conversation

@nareshkannasln

@nareshkannasln nareshkannasln commented Aug 13, 2026 •

Copy link
Copy Markdown
Collaborator

Closes: #5093

Description: When an employee has a loan with Repay from Salary, the printed Salary Slip does not add up. The loan repayment is subtracted from Net Pay but is never shown, so the reader cannot reconcile the slip.

image

@nareshkannasln
nareshkannasln marked this pull request as ready for review August 13, 2026 19:44
@mergify

mergify Bot commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@greptile-apps

greptile-apps Bot commented Aug 13, 2026 •

Copy link
Copy Markdown
Contributor

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Reviews (2): Last reviewed commit: "Merge branch 'develop' into salary-slip-..." | Re-trigger Greptile

@github-actions

Copy link
Copy Markdown

This pull request is being marked as inactive because of no recent activity.
If your PR hasn't been reviewed, it's likely because it doesn't fullfill the contribution guidelines. Please read them carefully and fix the pull request. When you are sure all items are checked, please ping relevant codeowner in the comment. Be nice, they have a lot on their plate too.

It will be closed in 3 days if no further activity occurs.
Thank you for contributing!

@github-actions github-actions Bot removed the Inactive label Sep 1, 2026
@deepeshgarg007

Copy link
Copy Markdown
Member

@nareshkannasln we have added new print formats for Salary Slips, can you add the loan repayment to that instead of the old one, we'll deprecate the old ones soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Salary Slip Preview deducts Loan Repayment from Net Pay but does not display it

2 participants