fix(salary-slip): show loan repayment in salary slip print formats - #5220
Merged
Merged
Conversation
nareshkannasln
force-pushed
the
loan-repayment-print-format
branch
from
September 7, 2026 08:51
eda5ec5 to
89f0369
Compare
nareshkannasln
marked this pull request as ready for review
September 7, 2026 10:42
nareshkannasln
requested review from
AyshaHakeem,
iamkhanraheel and
ruchamahabal
as code owners
September 7, 2026 10:42
Contributor
Confidence Score: 4/5Safe to merge with a non-blocking follow-up to complete the Detailed format’s YTD loan reporting. Current-period arithmetic is correct, but the Detailed format’s new loan row leaves YTD unreconciled. Files Needing Attention: hrms/payroll/print_format/salary_slip_detailed/salary_slip_detailed.json Prompt To Fix All With AI### Issue 1
hrms/payroll/print_format/salary_slip_detailed/salary_slip_detailed.json:13
**Loan YTD Is Missing**
The detailed format leaves the Year to Date cell blank for Total Loan Repayment, even though net-pay YTD includes these repayments. Recurring loans therefore remain difficult to reconcile year to date.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Reviews (1): Last reviewed commit: "fix(salary-slip): show loan repayment in..." | Re-trigger Greptile |
Contributor
|
Tick the box to add this pull request to the merge queue (same as
|
deepeshgarg007
added a commit
that referenced
this pull request
Sep 9, 2026
…5220 fix(salary-slip): show loan repayment in salary slip print formats (#5220)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #5093
Description: When an employee has a loan with Repay from Salary, the printed Salary Slip does not add up. The loan repayment is subtracted from Net Pay but is never shown, so the reader cannot reconcile the slip.
Follow-up to #5100 - added Loan Repayment to the new Salary Slip print formats as suggested in the review.