Skip to content

fix(salary-slip): show loan repayment in salary slip print formats - #5220

Merged
deepeshgarg007 merged 1 commit into
frappe:developfrom
aerele:loan-repayment-print-format
Sep 9, 2026
Merged

deepeshgarg007 merged 1 commit into
frappe:developfrom
aerele:loan-repayment-print-format

Conversation

@nareshkannasln

@nareshkannasln nareshkannasln commented Sep 7, 2026 •

Copy link
Copy Markdown
Collaborator

Closes: #5093

Description: When an employee has a loan with Repay from Salary, the printed Salary Slip does not add up. The loan repayment is subtracted from Net Pay but is never shown, so the reader cannot reconcile the slip.

image image image

Follow-up to #5100 - added Loan Repayment to the new Salary Slip print formats as suggested in the review.

@greptile-apps

greptile-apps Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Confidence Score: 4/5

Safe to merge with a non-blocking follow-up to complete the Detailed format’s YTD loan reporting.

Current-period arithmetic is correct, but the Detailed format’s new loan row leaves YTD unreconciled.

Files Needing Attention: hrms/payroll/print_format/salary_slip_detailed/salary_slip_detailed.json

Prompt To Fix All With AI
### Issue 1
hrms/payroll/print_format/salary_slip_detailed/salary_slip_detailed.json:13
**Loan YTD Is Missing**

The detailed format leaves the Year to Date cell blank for Total Loan Repayment, even though net-pay YTD includes these repayments. Recurring loans therefore remain difficult to reconcile year to date.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Reviews (1): Last reviewed commit: "fix(salary-slip): show loan repayment in..." | Re-trigger Greptile

@mergify

mergify Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

Tick the box to add this pull request to the merge queue (same as @mergifyio queue).

  • Queue this pull request

@deepeshgarg007
deepeshgarg007 merged commit 31f4bf6 into frappe:develop Sep 9, 2026
16 checks passed
deepeshgarg007 added a commit that referenced this pull request Sep 9, 2026
…5220

fix(salary-slip): show loan repayment in salary slip print formats (#5220)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Salary Slip Preview deducts Loan Repayment from Net Pay but does not display it

2 participants