Skip to content

[pigeon] pin native interop related dev deps and update some docs - #13103

Merged
auto-submit[bot] merged 4 commits into
flutter:mainfrom
tarrinneal:pigeon-objc-gen-docs
Oct 1, 2026
Merged

[pigeon] pin native interop related dev deps and update some docs#13103
auto-submit[bot] merged 4 commits into
flutter:mainfrom
tarrinneal:pigeon-objc-gen-docs

Conversation

@tarrinneal

@tarrinneal tarrinneal commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

related to dart-lang/native#3723

pins dev deps to avoid unexpected underlying changes to generated code or it's effects

@flutter-dashboard flutter-dashboard Bot added the CICD Run CI/CD label Oct 1, 2026
@tarrinneal
tarrinneal requested a review from QuncCccccc October 1, 2026 19:52
gemini-code-assist[bot]
gemini-code-assist Bot reviewed Oct 1, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request increments the Pigeon version to 29.0.6, updates JNI and Objective-C dependencies, and pins code generation dev_dependencies. It also updates the native interop guides and migration documentation to provide guidance on SwiftPM <plugin_name>_objc_gen target configuration. The review feedback points out technical inaccuracies in the documentation, specifically noting that the Pigeon toolchain and swift2objc generate the Objective-C bridging files, rather than ffigen.

Comment thread packages/pigeon/native_interop_guide.md
Comment thread packages/pigeon/skills/native-interop-migration/SKILL.md
Comment thread packages/pigeon/skills/native-interop-migration/SKILL.md
QuncCccccc
QuncCccccc approved these changes Oct 1, 2026
View reviewed changes

@QuncCccccc QuncCccccc left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix!

@tarrinneal tarrinneal added the autosubmit Merge PR when tree becomes green via auto submit App label Oct 1, 2026
@QuncCccccc QuncCccccc mentioned this pull request Oct 1, 2026
Closed
11 tasks done
@QuncCccccc QuncCccccc added the emergency Override tree-status signal (land even with closed tree), combine with the autosubmit label. label Oct 1, 2026
@flutter-dashboard

flutter-dashboard Bot commented Oct 1, 2026

Copy link
Copy Markdown

Detected the emergency label.

If you add the autosubmit label, the bot will wait until all presubmits pass but ignore the tree status, allowing fixes for tree breakages while still validating that they don't break any existing presubmits.

The "Merge" button is also unlocked. To bypass presubmits as well as the tree status, press the GitHub "Add to Merge Queue".

@auto-submit
auto-submit Bot merged commit ea212a2 into flutter:main Oct 1, 2026
11 of 12 checks passed
@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request Oct 2, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@QuncCccccc QuncCccccc QuncCccccc approved these changes
+1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD emergency Override tree-status signal (land even with closed tree), combine with the autosubmit label. p: pigeon

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tarrinneal @QuncCccccc