[pigeon] Pin ffigen and jnigen to fix the tree - #13093
Closed
QuncCccccc wants to merge 1 commit into
Closed
QuncCccccc wants to merge 1 commit into
QuncCccccc wants to merge 1 commit into
Conversation
ffigen 22.1.0 removed defaultCompilerOpts, which swiftgen 0.2.0 still uses, and jnigen 1.0.1 changes generated output so the checked-in JNI bindings no longer validate. Pin both dev_dependencies until upstream catches up.
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds upper bound constraints to the ffigen and jnigen dev_dependencies across multiple pubspec.yaml files in the pigeon package, its examples, and platform tests. Specifically, ffigen is restricted to '>=22.0.0 <22.1.0' and jnigen is restricted to '>=1.0.0 <1.0.1' to address compatibility issues with swiftgen. There are no review comments, and I have no feedback to provide.
Contributor
Author
|
Talked with @tarrinneal offline and a fix with some other changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the red tree on
main(Mac_arm64 custom_package_tests master/stable,Linux_android custom_package_tests master), which is also blocking the flutter→packages roll (#13091).No change in this repo caused it:
d5ec6dbaf1was green and the next commit (249ddc0d0b, docs-only) was red. The breakage started with the first CI run after dart-lang/native published new versions of pigeon's dev_dependencies (~02:51 UTC 2026-10-01, via dart-lang/native#3716):ffigen 22.1.0removeddefaultCompilerOptsfrom its public API, but the latestswiftgen(0.2.0) still calls it, so FFIgen generation fails on macOS:swiftgen-0.2.0/lib/src/generator.dart:101:17: Error: Method not found: 'defaultCompilerOpts'.(build)
jnigen 1.0.1changes the generated header andJniVersionCheck(1, 0)→(1, 1), so the checked-innative_interop_tests.gen.jni.dartno longer matches generator output on Linux.(build)
This pins both (
ffigen ">=22.0.0 <22.1.0",jnigen ">=1.0.0 <1.0.1") in the four pigeon pubspecs that depend on them, with TODOs to remove the pins once upstream is fixed. These are alldev_dependencies, so there is no impact on pigeon clients; the top-levelpubspec.yamlchange isn't auto-exempted by the repo tool, so this needsoverride: no versioning neededandoverride: no changelog needed.Verified locally:
swiftgen+ the test plugin's ffigen config compile; withffigen 22.1.0the same compile fails with the CI error above.jnigen 1.0.0, which is what the pin resolves to (same as the last green run).Upstream issue: dart-lang/native#3723
Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2