fix(ci): drop hardcoded pnpm version, defer to packageManager#12
Merged
JohnMcLear merged 2 commits intomainfrom May 8, 2026
Merged
fix(ci): drop hardcoded pnpm version, defer to packageManager#12JohnMcLear merged 2 commits intomainfrom
JohnMcLear merged 2 commits intomainfrom
Conversation
ⓘ You've reached your Qodo monthly free-tier limit. Reviews pause until next month — upgrade your plan to continue now, or link your paid account if you already have one. |
The publish job checks out etherpad-lite core first (pinned to pnpm@11 via packageManager); pnpm/action-setup@v6 then errors with 'Multiple versions of pnpm specified' because the workflow's version: 10 clashes with the checked-out repo's packageManager. Removing 'version:' lets action-setup take pnpm@11 from packageManager, which is what we actually want for compatibility with the rest of the plugin ecosystem and what the test job already does.
action-setup infers the pnpm version from this field. The test job doesn't check out an upstream repo, so without it action-setup errors 'No pnpm version is specified'.
JohnMcLear
force-pushed
the
fix/pnpm-version-conflict
branch
from
739225c to
6a6fc11
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The post-merge release run for #11 failed with:
The publish job runs
actions/checkout@v6forether/etherpad-litefirst (pinned to pnpm@11 viapackageManager), thenpnpm/action-setup@v6withversion: 10. Action-setup balks at the mismatch.Drop the hardcoded
version: 10from both workflows so action-setup takes the pnpm version frompackageManager(which is the desired source of truth across the rest of the plugin ecosystem). After this lands, the next merge to main will trigger a clean publish of v0.5.x.Test plan
Install pnpm.🤖 Generated with Claude Code