fix(ci): drop hardcoded pnpm version, defer to packageManager#2
Merged
JohnMcLear merged 1 commit intomainfrom May 8, 2026
Merged
fix(ci): drop hardcoded pnpm version, defer to packageManager#2JohnMcLear merged 1 commit intomainfrom
JohnMcLear merged 1 commit intomainfrom
Conversation
Same fix as ep_plugin_helpers#12. The publish job checks out etherpad-lite (pinned to pnpm@11 via packageManager) into cwd, then pnpm/action-setup@v6 errors on the version mismatch. Removing the 'version:' line lets action-setup take the version from packageManager (now pinned to pnpm@11.0.6 here too).
ⓘ You've reached your Qodo monthly free-tier limit. Reviews pause until next month — upgrade your plan to continue now, or link your paid account if you already have one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The release run that fired after PR #1 merged failed at
Install pnpm:The publish job checks out
ether/etherpad-lite(pinned to pnpm@11 via packageManager) into cwd, thenpnpm/action-setup@v6errors on the version mismatch.This is the same fix that landed in ep_plugin_helpers#12. Without
version:action-setup takes the version frompackageManager(now pinned to pnpm@11.0.6 in this plugin's package.json too).After this lands the release job will reach the publish step and
ep_syntax_highlighting@0.1.xwill appear on npm.Test plan
🤖 Generated with Claude Code