Skip to content

fix(ci): drop hardcoded pnpm version, defer to packageManager#2

Merged
JohnMcLear merged 1 commit intomainfrom
fix/pnpm-version-conflict
May 8, 2026
Merged

fix(ci): drop hardcoded pnpm version, defer to packageManager#2
JohnMcLear merged 1 commit intomainfrom
fix/pnpm-version-conflict

Conversation

@JohnMcLear
Copy link
Copy Markdown
Member

Summary

The release run that fired after PR #1 merged failed at Install pnpm:

Error: Multiple versions of pnpm specified:

  • version 10 in the GitHub Action config with the key "version"
  • version pnpm@11.0.6 in the package.json with the key "packageManager"

The publish job checks out ether/etherpad-lite (pinned to pnpm@11 via packageManager) into cwd, then pnpm/action-setup@v6 errors on the version mismatch.

This is the same fix that landed in ep_plugin_helpers#12. Without version: action-setup takes the version from packageManager (now pinned to pnpm@11.0.6 in this plugin's package.json too).

After this lands the release job will reach the publish step and ep_syntax_highlighting@0.1.x will appear on npm.

Test plan

  • Same fix exercised cleanly in ep_plugin_helpers#12 → produced 0.5.1 on npm.
  • Will be exercised here on merge.

🤖 Generated with Claude Code

Same fix as ep_plugin_helpers#12. The publish job checks out
etherpad-lite (pinned to pnpm@11 via packageManager) into cwd, then
pnpm/action-setup@v6 errors on the version mismatch. Removing the
'version:' line lets action-setup take the version from
packageManager (now pinned to pnpm@11.0.6 here too).
@qodo-code-review
Copy link
Copy Markdown

ⓘ You've reached your Qodo monthly free-tier limit. Reviews pause until next month — upgrade your plan to continue now, or link your paid account if you already have one.

@JohnMcLear JohnMcLear merged commit 5058fb4 into main May 8, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant