Repository navigation
fix: keep // comment keys with the field below them in package.json - #73
Merged
Merged
Conversation
Member
Author
|
This only did top level. Doing a new pr for nested sections. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #72
With
packageJson.applyConventions, a top level key starting with//("//","// node", ...) was treated as an unknown field and sorted to the end of the file, away from the field it was written to describe.Such a key now travels with the field written below it, the same way a real comment does:
Not changed here:
engines,bin, the dependency sections) are still sorted as ordinary names