Repository navigation
fix: keep // comment keys with the field below them in sorted package.json sections - #74
Merged
Merged
Conversation
…ge.json sections
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #73 (#72).
#73 made a top level key starting with
//travel with the field written below it. Inside the sections that are sorted alphabetically (bin,engines, the dependency sections,overrides) such a key was still sorted as an ordinary name, so it ended up at the top of the section, away from the entry it describes.The same rule now applies in those sections: a comment key always moves with the next field.
"//"keys inoverridesno longer count as one package named twice, which stopped the section from being sorted at all. A real duplicate still leaves it alone