Repository navigation
Conversation
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…lling-interval IS-11797 Rename pollingInterval config to defaultPollingInterval
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The public configuration rename breaks existing typed consumers and silently changes behavior for JavaScript consumers.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Updates polling interval handling so valid server intervals take precedence and malformed values use a renamed fallback configuration.
Changes:
- Renames
pollingIntervaltodefaultPollingInterval. - Validates server-provided polling intervals.
- Adds polling-step unit coverage and updates mocks/integration tests.
| File | Description |
|---|---|
util/tests/mocks.ts |
Updates config and polling mocks. |
step-handlers/polling-step.ts |
Resolves and validates polling intervals. |
step-handlers/polling-step.spec.ts |
Adds polling-handler tests. |
HaapiStepper.tsx |
Renames the default configuration field. |
HaapiStepper.spec.tsx |
Updates tests for the renamed field. |
haapi-stepper.types.ts |
Changes and documents the public configuration API. |
previewer/Previewer.tsx |
Updates preview configuration. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
aleixsuau
approved these changes
Sep 30, 2026
This was referenced Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.