Skip to content

fix: update sceme validation rules + tenderly types #211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shoom3301 merged 6 commits into from
Apr 28, 2026
+9 −8
Merged

fix: update sceme validation rules + tenderly types #211

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e554512
fix: update sceme validation rules + tenderly types
limitofzero Apr 14, 2026
47e0d21
Merge branch 'main' into fix/tenderly-validation-scheme-types
limitofzero Apr 22, 2026
e076f36
fix: add null check for diff
limitofzero Apr 23, 2026
b1302f7
fix: use ??
limitofzero Apr 23, 2026
582a279
chore: add comment
limitofzero Apr 23, 2026
c77919e
Merge branch 'main' into fix/tenderly-validation-scheme-types
shoom3301 Apr 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apps/api/src/app/routes/__chainId/simulation/simulateBundle.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,12 +85,12 @@ const successSchema = {
original: {
title: 'Original',
description: 'Original value before the state change',
type: ['string', 'object', 'null'],
type: ['string', 'number', 'boolean', 'object', 'array', 'null'],
},
dirty: {
title: 'Dirty',
description: 'New value after the state change',
type: ['string', 'object', 'null'],
type: ['string', 'number', 'boolean', 'object', 'array', 'null'],
},
raw: {
title: 'Raw Elements',
Expand Down
4 changes: 2 additions & 2 deletions libs/repositories/src/repos/SimulationRepository/tenderlyTypes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -578,8 +578,8 @@ interface LogRaw {
export interface StateDiff {
address: string;
soltype: SoltypeElement | null;
original: string | Record<string, any> | null;
dirty: string | Record<string, any> | null;
original: string | number | boolean | Record<string, any> | unknown[] | null;
dirty: string | number | boolean | Record<string, any> | unknown[] | null;
Comment thread
coderabbitai[bot] marked this conversation as resolved.
raw?: RawElement[];
}

Expand Down
9 changes: 5 additions & 4 deletions libs/repositories/src/utils/buildStateDiff.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,9 +134,9 @@ function processRawOnlyDiff(
if (!updated) {
const newDiff: StateDiff = {
address: diff.address,
soltype: diff.soltype || null,
original: diff.original || null,
dirty: diff.dirty || null,
soltype: diff.soltype ?? null,
original: diff.original ?? null,
dirty: diff.dirty ?? null,
raw: [structuredClone<typeof rawElement>(rawElement)],
};

Expand All @@ -153,7 +153,8 @@ function processSingleDiff(
diff: StateDiff
): StateDiff[] {
// Handle regular diffs (with complete soltype, original, dirty data)
if (diff?.soltype && diff?.original && diff?.dirty) {
// Using != null (loose check) intentionally to catch both null and undefined
if (diff?.soltype != null && diff?.original != null && diff?.dirty != null) {
Copy link
Copy Markdown
Collaborator

@alfetopito alfetopito Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: is it intentional to do a loose check instead of strict? (!= vs !==)

Copy link
Copy Markdown
Contributor Author

@limitofzero limitofzero Apr 23, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it checks null and undefined at the same moment, I will add comment

return processRegularDiff(accumulatedStateDiff, diff);
}
// Handle raw-only diffs (missing soltype, original, or dirty)
Expand Down
Loading