fix: update sceme validation rules + tenderly types

[limitofzero]

Tenderly simulation runs successfully, but when our BFF tries to serialize the response, Fastify's schema validation fails: The value of '#/items/properties/stateDiff/items/properties/original' does not match schema definition and it returns 500

Summary by CodeRabbit

• Improvements

  • Simulation bundle endpoint now accepts numbers, booleans, and arrays for state-diff entries in addition to strings, objects, and nulls.

• Bug Fixes

  • Preserves falsy values (e.g., 0, false, empty arrays) when normalizing state diffs to avoid misclassifying valid values as missing.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 6393d959-a0e0-41eb-be10-cd9cf086bc2a

📥 Commits

Reviewing files that changed from the base of the PR and between e076f36 and 582a279.

📒 Files selected for processing (1)

• libs/repositories/src/utils/buildStateDiff.ts

---

📝 Walkthrough

Walkthrough

JSON schema, TypeScript types, and normalization logic for state diffs were widened to allow number, boolean, and arrays for original/dirty, and nullish checks now preserve falsy-but-valid values (e.g., 0, false, []) during diff processing.

Changes

Cohort / File(s)	Summary
API Schema apps/api/src/app/routes/__chainId/simulation/simulateBundle.ts	Updated JSON schema for stateDiff entries so original and dirty also accept number, boolean, and array types in addition to string, object, and null.
Type Definitions libs/repositories/src/repos/SimulationRepository/tenderlyTypes.ts	Expanded exported StateDiff interface: original and dirty now include number, boolean, and unknown[] alongside existing string, Record<string, any>, and null.
Normalization Logic libs/repositories/src/utils/buildStateDiff.ts	Changed diff construction to use nullish handling (?? null) and nullish checks (!= null) so falsy but valid values (e.g., 0, false, []) are preserved and not misclassified as missing.

Sequence Diagram(s)

sequenceDiagram
  participant Client
  participant API
  participant Validator
  participant Normalizer
  participant Repo
  Client->>API: POST /simulateBundle with stateDiff
  API->>Validator: validate request schema
  Validator-->>API: validation result (accepts numbers/booleans/arrays)
  API->>Normalizer: pass raw stateDiff entries
  Normalizer->>Repo: normalized diffs (uses ?? / != null to keep falsy values)
  Repo-->>API: stored/processed result
  API-->>Client: response

Loading

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 A rabbit's ode to broader bounds:
Numbers hop in, booleans cheer,
Arrays tumble, once held dear.
Falsy friends no longer lost,
State diffs find their worth, not cost. 🥕

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title mentions 'sceme' (likely a typo for 'schema') and broadly references schema validation and Tenderly types, which aligns with the changes that update JSON schema validation rules and the StateDiff type definitions.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/tenderly-validation-scheme-types

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@libs/repositories/src/repos/SimulationRepository/tenderlyTypes.ts`:
- Around line 581-582: The widened types in tenderlyTypes (properties
diff.original and diff.dirty now allow 0/false) break downstream logic in
buildStateDiff.ts that uses truthy checks and ||; update the merge/guard logic
in libs/repositories/src/utils/buildStateDiff.ts to use explicit null/undefined
checks (e.g., diff.original !== undefined && diff.original !== null) and replace
usages of the || operator with nullish coalescing or explicit checks so valid
falsy values (0, false, empty string) are preserved when computing/merging
state; ensure any conditional like if (diff?.original && diff?.dirty) is changed
to test for non-null/undefined values instead.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 0bd1daa8-cb77-4f19-ab0d-a84ecabd2f22

📥 Commits

Reviewing files that changed from the base of the PR and between 07f7932 and e554512.

⛔ Files ignored due to path filters (1)

• libs/repositories/src/gen/cow/cow-api-types.ts is excluded by !**/gen/**

📒 Files selected for processing (2)

• apps/api/src/app/routes/__chainId/simulation/simulateBundle.ts
• libs/repositories/src/repos/SimulationRepository/tenderlyTypes.ts

[alfetopito]

@coderabbitai review

[coderabbitai]

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

[alfetopito]

Nitpick: is it intentional to do a loose check instead of strict? (!= vs !==)

[limitofzero]

yes, it checks null and undefined at the same moment, I will add comment