Conversation
prep for picking up go 1.25 in an upcoming commit
Contributor
There was a problem hiding this comment.
Pull request overview
Updates CI/tooling configuration in preparation for a future Go toolchain bump, and introduces optional pre-commit hooks to help keep local formatting/licensing/linting consistent with CI.
Changes:
- Add
.pre-commit-config.yamlwith local hooks for addlicense, goimports, and golangci-lint. - Refactor
.github/workflows/ci.ymlto centralize action/tool versions via YAML anchors and bump Go/golangci-lint/test-annotations versions. - Add an explanatory comment in
views.goabout usingsort.Sortinstead ofslices.SortFunc.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
views.go |
Adds rationale comment for the chosen in-place sort approach. |
.pre-commit-config.yaml |
Adds optional pre-commit hooks for license headers, imports, and linting. |
.github/workflows/ci.yml |
Centralizes versions and updates Go/lint/test-annotation tooling in CI. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+24
to
+28
| env: | ||
| ACTIONS_CHECKOUT_VERSION: &actions_checkout_version actions/checkout@v6 | ||
| ACTIONS_SETUP_GO_VERSION: &actions_setup_go_version actions/setup-go@v6 | ||
| GO_VERSION: &go_version 1.26.4 | ||
| GO_TEST_ANNOTATIONS_VERSION: &go_test_annotations_version guyarb/golang-test-annotations@v0.9.0 |
Contributor
Author
There was a problem hiding this comment.
I'm OK about this mismatch. I think a lower version is OK for go.mod if we ever have to backport sg-bucket fixes to an older release.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
RIT3shSapata
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
prep for picking up go 1.25 in an upcoming commit
prereq for #146
add pre-commit support (see couchbase/sync_gateway#8379). Use of this is optional.