Conversation
There was a problem hiding this comment.
Pull request overview
Adds a repository-level pre-commit configuration and updates the GitHub Actions CI workflow to align tooling and versions with the referenced sg-bucket change set.
Changes:
- Introduces
.pre-commit-config.yamlwith local hooks foraddlicense,goimports, andgolangci-lint. - Updates CI to newer Go/tooling versions (Go
1.26.4,golangci-lintv2.12.2, test annotationsv0.9.0) and factors repeateduses:values via YAML anchors. - Expands
test-raceto run acrossmacos-latest,windows-latest, andubuntu-latest.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| .pre-commit-config.yaml | Adds local pre-commit hooks to enforce license headers, import formatting, and linting. |
| .github/workflows/ci.yml | Updates Go/tooling versions, deduplicates action versions with anchors, and broadens test-race coverage via an OS matrix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| - id: addlicense | ||
| name: addlicense | ||
| language: system | ||
| entry: go run github.com/google/addlicense@latest -f licenses/addlicense.tmpl |
Collaborator
Author
There was a problem hiding this comment.
I'm OK not fixing this because this matches ci.yml
RIT3shSapata
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CBG-5480 setup pre-commit and update CI
Update with same code as couchbase/sg-bucket#147