Cloud discovery - #228
Draft
alec-w wants to merge 3 commits into
Draft
Conversation
Contributor
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
|
The latest Buf updates on your PR. Results from workflow buf-ci / buf (pull_request).
|
Draft
markgoddard
reviewed
Aug 12, 2026
| // Time of last resource update. | ||
| google.protobuf.Timestamp last_updated_at = 7 [(google.api.field_behavior) = OUTPUT_ONLY]; | ||
| // When true, discovery is suspended for this account and existing discovered resources are hidden from findings. | ||
| bool suppressed = 8 [(google.api.field_behavior) = OPTIONAL]; |
Member
There was a problem hiding this comment.
discovery_suppressed? or discovery_enabled to match the org?
| // Whether the first role in role_chain is assumed via SPIFFE JWT-based | ||
| // AssumeRoleWithWebIdentity (true, the default) or via ambient credentials | ||
| // such as EKS Pod Identity (false). | ||
| bool assume_through_oidc = 9 [(google.api.field_behavior) = OPTIONAL]; |
Member
There was a problem hiding this comment.
group with other auth fields?
| // when false, the first role is assumed via plain AssumeRole using ambient | ||
| // credentials (e.g. EKS Pod Identity). Each subsequent role is always assumed | ||
| // using the credentials from the prior step. | ||
| repeated proto.cloud_provider.v1alpha1.AWSAssumeRoleConfig role_chain = 7 [(google.api.field_behavior) = REQUIRED]; |
Member
There was a problem hiding this comment.
Is there a common message to factor out here including audience, role_chain and assume_through_oidc?
| bool assume_through_oidc = 9 [(google.api.field_behavior) = OPTIONAL]; | ||
| } | ||
|
|
||
| // AWSAgentCoreDiscoveryConfig contains configuration for Amazon Bedrock AgentCore Runtime discovery. |
Member
There was a problem hiding this comment.
Same fields as AWSLambdaDiscoveryConfig? Could they diverge?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.