Improve httpgenerator-core rustdoc#405
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (30)
📝 WalkthroughWalkthroughThis pull request adds comprehensive Rustdoc documentation across the ChangesComprehensive Rustdoc and library documentation enhancement
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Suggested labels
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
There was a problem hiding this comment.
Pull request overview
This PR improves the public docs.rs surface of httpgenerator-core by adding crate/module/item rustdoc throughout the Rust core library, and by enabling #![warn(missing_docs)] to keep documentation coverage from regressing over time.
Changes:
- Added crate-level/module-level rustdoc that explains the generation + normalization flow and how to use the OpenAPI helpers.
- Documented public types/APIs across
model,normalized,openapi, and utility modules, including runnable (orno_run) examples. - Enabled
#![warn(missing_docs)]inhttpgenerator-coreto surface future public API documentation gaps as warnings.
Reviewed changes
Copilot reviewed 30 out of 30 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| src/rust/core/src/support_information.rs | Documents support identity/key helpers and adds examples. |
| src/rust/core/src/string_extensions.rs | Documents string casing/format helpers and adds examples. |
| src/rust/core/src/privacy.rs | Documents authorization header redaction behavior and example. |
| src/rust/core/src/operation_name.rs | Documents operation name generation rules and examples. |
| src/rust/core/src/openapi/version.rs | Documents OpenAPI version enum + version detection helper. |
| src/rust/core/src/openapi/typed.rs | Documents typed OpenAPI parsing surface and limitations. |
| src/rust/core/src/openapi/source.rs | Documents source classification and OpenApiSource helpers. |
| src/rust/core/src/openapi/raw.rs | Documents raw document type + load/decode entry points. |
| src/rust/core/src/openapi/normalize/mod.rs | Documents top-level normalize entry points and examples. |
| src/rust/core/src/openapi/mod.rs | Adds module-level docs describing the OpenAPI API layers. |
| src/rust/core/src/openapi/loader.rs | Documents “loaded document” enum and load entry points. |
| src/rust/core/src/openapi/inspect/model.rs | Documents inspection result/stats structs and fields. |
| src/rust/core/src/openapi/inspect/mod.rs | Documents inspection entry points and example usage. |
| src/rust/core/src/openapi/format.rs | Documents format detection/sniffing and examples. |
| src/rust/core/src/openapi/error.rs | Documents OpenAPI-related error enums and their variants/fields. |
| src/rust/core/src/normalized/schema.rs | Documents normalized schema types used by renderer/samples. |
| src/rust/core/src/normalized/request_body.rs | Documents normalized request-body shapes and fields. |
| src/rust/core/src/normalized/parameter.rs | Documents normalized parameter shapes and fields. |
| src/rust/core/src/normalized/mod.rs | Adds module-level docs describing the normalized model. |
| src/rust/core/src/normalized/http.rs | Documents normalized HTTP method + parameter location enums. |
| src/rust/core/src/normalized/document.rs | Documents normalized document/server/operation structures. |
| src/rust/core/src/model/settings.rs | Documents generator settings and clarifies field meanings. |
| src/rust/core/src/model/result.rs | Documents HttpFile + GeneratorResult and adds examples. |
| src/rust/core/src/model/output_type.rs | Documents output grouping modes and their behavior. |
| src/rust/core/src/model/mod.rs | Adds module-level docs for settings/output types. |
| src/rust/core/src/lib.rs | Adds crate-level docs, re-export guidance, and enables warn(missing_docs). |
| src/rust/core/src/generator/modes.rs | Documents generate_http_files behavior and example. |
| src/rust/core/src/generator/mod.rs | Adds module-level docs for the renderer. |
| src/rust/core/src/file_naming.rs | Documents unique filename helper and example. |
| src/rust/core/src/base_url.rs | Documents base URL resolution rules and example. |



httpgenerator-coreis the public library surface shown on docs.rs, but many exported items lacked rustdoc. This change makes the crate documentation more useful for downstream users by explaining the main generation flow, normalized model, OpenAPI helpers, and public utility APIs.Summary
no_runfor file or URL loading flows.#![warn(missing_docs)]so future public API documentation gaps are visible without blocking development.Validation
RUSTDOCFLAGS="-D warnings" cargo doc -p httpgenerator-core --no-depscargo test --workspaceSummary by CodeRabbit
Release Notes
Documentation
New Features
OpenApiInspectionto include statistics for better document analysis.