Conversation
mabruzzo
changed the title
Grav3D use SpatialDomainPropsGrav3D use SpatialDomainProps
Merged
mabruzzo
force-pushed
the
grav-use-spatial_domain_props
branch
2 times, most recently
from
August 31, 2026 14:41
6402ba2 to
62a3327
Compare
mabruzzo
force-pushed
the
grav-use-spatial_domain_props
branch
from
August 31, 2026 14:41
62a3327 to
859d0af
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small, straight-forward PR to make
Grav3Ddirectly store a copy ofSpatialDomainProps.Currently, all of the members of
SpatialDomainPropsare also listed as members ofGrav3D(this was an intentional choice back when I made it possible to initialize particles without Gravity). This is just some long overdue cleanup (it's been on my todo list for quite a while).There is a minor merge conflict with PR #521 -- I'm happy to resolve those conflicts in whatever order they are merged
Longer term, I would also like to store a copy of
SpatialDomainPropswithinParticles3D; currently, copies of all ofSpatialDomainProps's data members are stored within theParticles3D::Gridtype (the names are all consistent too). But, that's somewhat beyond the scope of this PR.