Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR lightly refactors the codebase so that we now define a very simplistic
SphericalOverdensitymodel.The main thing that changes here are that:
Header::sphere_radius,Header::sphere_*, data members are now tracked in a dedicated model objectinitruntime parameterMotivation: This PR, #524 and #525 will all be required in order to cleanup the
Grav3Dclass. Plus, this is a much more simple example of the kinds of things that should be implemented as model objects.Note
I was very careful to try to avoid breaking things. However, I'm pretty sure that test-problems leveraging this machinery are fundamentally broken. Unless I'm totally off-base, this requires non-periodic boundaries (if we want to run it with periodic boundaries, then we can cull lots of things -- this doesn't even need to be a model). Since SOR doesn't work, I think we're run this with Periodic Paris. But, we'll see as I continue trying to clean things up