Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions packages/catalog/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,9 @@
"ember-modify-based-class-resource": "catalog:"
},
"scripts": {
"catalog:setup": "([ -d contents ] || git clone git@github.com:cardstack/boxel-catalog.git contents || git clone https://github.com/cardstack/boxel-catalog.git contents || { echo 'both ssh and https clone failed; check GitHub auth and network'; exit 1; }) && pnpm catalog:rewrite-legacy-aliases",
"catalog:update": "sh scripts/catalog-update.sh && pnpm catalog:rewrite-legacy-aliases",
"catalog:setup": "[ -d contents ] || git clone git@github.com:cardstack/boxel-catalog.git contents || git clone https://github.com/cardstack/boxel-catalog.git contents || { echo 'both ssh and https clone failed; check GitHub auth and network'; exit 1; }",
"catalog:update": "sh scripts/catalog-update.sh",
"catalog:reset": "rm -rf contents && pnpm catalog:setup",
"catalog:rewrite-legacy-aliases": "node ./scripts/rewrite-legacy-aliases.mjs",
"lint": "concurrently \"pnpm:lint:*(!fix)\" --names \"lint:\"",
"lint:fix": "concurrently \"pnpm:lint:*:fix\" --names \"fix:\"",
"lint:hbs": "ember-template-lint contents --no-error-on-unmatched-pattern",
Expand Down
179 changes: 0 additions & 179 deletions packages/catalog/scripts/rewrite-legacy-aliases.mjs

This file was deleted.

5 changes: 0 additions & 5 deletions packages/host/app/commands/get-available-realm-urls.ts

This file was deleted.

5 changes: 0 additions & 5 deletions packages/host/app/commands/get-catalog-realm-urls.ts

This file was deleted.

5 changes: 0 additions & 5 deletions packages/host/app/commands/get-realm-of-url.ts

This file was deleted.

32 changes: 0 additions & 32 deletions packages/host/app/commands/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -97,19 +97,6 @@ import * as ValidateRealmCommandModule from './validate-realm';
import * as WriteBinaryFileCommandModule from './write-binary-file';
import * as WriteTextFileCommandModule from './write-text-file';

// Deprecated URL-flavored aliases kept for backwards compatibility with
// boxel-skills/boxel-catalog cards still referencing the old module
// paths. Each module is a thin re-export of its renamed counterpart.
// Remove this block (imports + shimModule calls below + the .ts files
// themselves) once downstream consumers have been on the renamed paths
// for at least one release. Tracked by CS-11046.
/* eslint-disable import/order */
import * as GetRealmOfUrlCommandModule from './get-realm-of-url';
import * as GetAvailableRealmUrlsCommandModule from './get-available-realm-urls';
import * as GetCatalogRealmUrlsCommandModule from './get-catalog-realm-urls';
import * as InvalidateRealmUrlsCommandModule from './invalidate-realm-urls';
/* eslint-enable import/order */

import type HostBaseCommand from '../lib/host-base-command';

export function shimHostCommands(virtualNetwork: VirtualNetwork) {
Expand Down Expand Up @@ -501,25 +488,6 @@ export function shimHostCommands(virtualNetwork: VirtualNetwork) {
'@cardstack/boxel-host/commands/set-user-system-card',
SetUserSystemCardCommandModule,
);

// Deprecated URL-flavored aliases — see the import-block comment for
// these modules above. Tracked by CS-11046.
virtualNetwork.shimModule(
'@cardstack/boxel-host/commands/get-realm-of-url',
GetRealmOfUrlCommandModule,
);
virtualNetwork.shimModule(
'@cardstack/boxel-host/commands/get-available-realm-urls',
GetAvailableRealmUrlsCommandModule,
);
virtualNetwork.shimModule(
'@cardstack/boxel-host/commands/get-catalog-realm-urls',
GetCatalogRealmUrlsCommandModule,
);
virtualNetwork.shimModule(
'@cardstack/boxel-host/commands/invalidate-realm-urls',
InvalidateRealmUrlsCommandModule,
);
}

// Note - this is used for the tests
Expand Down
5 changes: 0 additions & 5 deletions packages/host/app/commands/invalidate-realm-urls.ts

This file was deleted.

12 changes: 0 additions & 12 deletions packages/host/memory-baseline.json
Original file line number Diff line number Diff line change
Expand Up @@ -303,24 +303,15 @@
"Integration | commands | get-available-realm-identifiers": {
"delta_mb": -2.2
},
"Integration | commands | get-available-realm-urls": {
"delta_mb": -4.3
},
"Integration | commands | get-catalog-realm-identifiers": {
"delta_mb": 0.6
},
"Integration | commands | get-catalog-realm-urls": {
"delta_mb": -11.9
},
"Integration | commands | get-default-writable-realm": {
"delta_mb": 7
},
"Integration | commands | get-realm-of-resource-identifier": {
"delta_mb": 0
},
"Integration | commands | get-realm-of-url": {
"delta_mb": 0.2
},
"Integration | commands | get-user-system-card": {
"delta_mb": 0.3
},
Expand All @@ -330,9 +321,6 @@
"Integration | commands | invalidate-realm-identifiers": {
"delta_mb": -16
},
"Integration | commands | invalidate-realm-urls": {
"delta_mb": -9.9
},
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this make sense to include in this PR, @lukemelia? I imagine renamed/deleted modules might linger forever.

"Integration | commands | invite-user-to-room": {
"delta_mb": 6.1
},
Expand Down
7 changes: 3 additions & 4 deletions packages/skills-realm/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,8 @@
"version": "1.0.0",
"license": "MIT",
"scripts": {
"skills:setup": "([ -d contents ] || (git clone git@github.com:cardstack/boxel-skills.git contents || git clone https://github.com/cardstack/boxel-skills.git contents)) && pnpm skills:rewrite-legacy-aliases",
"skills:update": "pnpm skills:setup && cd contents && git pull && cd .. && pnpm skills:rewrite-legacy-aliases",
"skills:reset": "rm -rf contents && pnpm skills:setup",
"skills:rewrite-legacy-aliases": "node ./scripts/rewrite-legacy-aliases.mjs"
"skills:setup": "[ -d contents ] || git clone git@github.com:cardstack/boxel-skills.git contents || git clone https://github.com/cardstack/boxel-skills.git contents",
"skills:update": "pnpm skills:setup && cd contents && git pull",
"skills:reset": "rm -rf contents && pnpm skills:setup"
}
}
71 changes: 0 additions & 71 deletions packages/skills-realm/scripts/rewrite-legacy-aliases.mjs

This file was deleted.

Loading