Skip to content

Remove transitional command/parameter rename code#4771

Open
backspace wants to merge 3 commits into
mainfrom
command-rename-shims-cs-11046
Open

Remove transitional command/parameter rename code#4771
backspace wants to merge 3 commits into
mainfrom
command-rename-shims-cs-11046

Conversation

@backspace
Copy link
Copy Markdown
Contributor

#4627 renamed commands and their parameters to not assume realm and resource URLs. #4730 restored the old imports for the transitional period before the boxel-skills PR was deployed in staging and production. Now that everywhere has the correct imports and parameter names, we don’t need these shims and rewrite scripts.

},
"Integration | commands | invalidate-realm-urls": {
"delta_mb": -9.9
},
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this make sense to include in this PR, @lukemelia? I imagine renamed/deleted modules might linger forever.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 11, 2026

Preview deployments

Host Test Results

    1 files      1 suites   2h 4m 55s ⏱️
2 654 tests 2 639 ✅ 15 💤 0 ❌
2 673 runs  2 658 ✅ 15 💤 0 ❌

Results for commit 57a6c19.

Realm Server Test Results

    1 files      1 suites   12m 6s ⏱️
1 320 tests 1 320 ✅ 0 💤 0 ❌
1 399 runs  1 399 ✅ 0 💤 0 ❌

Results for commit 57a6c19.

@backspace backspace marked this pull request as ready for review May 11, 2026 21:20
@jurgenwerk jurgenwerk requested a review from Copilot May 12, 2026 12:31
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the temporary “URL-flavored” command/module-path compatibility shims and the associated rewrite scripts that were introduced to bridge the urlidentifier rename during downstream rollout. This simplifies the host command surface back to a single canonical set of command module paths and removes now-unneeded post-clone mutation steps for catalog/skills contents.

Changes:

  • Deleted legacy alias rewrite scripts in packages/skills-realm and packages/catalog, and removed their invocation from package scripts.
  • Removed deprecated host command alias modules (*-urls / get-realm-of-url) and the corresponding virtualNetwork.shimModule() registrations.
  • Pruned legacy command entries from the host memory baseline.

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/skills-realm/scripts/rewrite-legacy-aliases.mjs Removes the skills contents rewrite shim now that downstream imports are updated.
packages/skills-realm/package.json Drops the rewrite step from skills:* scripts.
packages/host/memory-baseline.json Removes baseline entries for deleted legacy command integration cases.
packages/host/app/commands/invalidate-realm-urls.ts Deletes deprecated alias module (re-export).
packages/host/app/commands/index.ts Removes legacy alias imports and shimModule() registrations.
packages/host/app/commands/get-realm-of-url.ts Deletes deprecated alias module (re-export).
packages/host/app/commands/get-catalog-realm-urls.ts Deletes deprecated alias module (re-export).
packages/host/app/commands/get-available-realm-urls.ts Deletes deprecated alias module (re-export).
packages/catalog/scripts/rewrite-legacy-aliases.mjs Removes the catalog contents rewrite shim now that downstream sources are updated.
packages/catalog/package.json Drops the rewrite step from catalog:* scripts.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@backspace backspace requested a review from a team May 12, 2026 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants