RFC: Fallback dialog - #3257
Draft
infirit wants to merge 1 commit into
Draft
Conversation
These dialogs don't have any buttons or a close button on the window. They also don't need to persist forever unless requested with a timeout of 0.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was testing some things because of #3252 and the fallback dialog is quite annoying to deal with. It has no button on the window to close and most of the time we don't add any (action) buttons. Thus it's very annoying to close notifications from ConnectionNotifier, AutoConnect and RecentCons.
This PR closes the window automatically unless the requested timeout is 0. We can do this or change the dialog to include window buttons so people can close it.
Also, the transparency doesn't really add much and makes it hard to read unless you enter it with your mouse.